fix empty queue condition for queue shutdown drain #7575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged we should move forward with #7583 |
colinsurprenant
changed the title
|
ping @guyboertje |
This was referenced Jul 10, 2017
colinsurprenant
force-pushed
the
fix/queue_empty
branch
2 times, most recently
from
d983867 to
7e521c9
Compare
page test queue test move is_empty? at queue level new wrapped acked queue spec
colinsurprenant
force-pushed
the
fix/queue_empty
branch
from
7e521c9 to
aedf397
Compare
colinsurprenant
added a commit
that referenced
this pull request
Jul 18, 2017
page test queue test move is_empty? at queue level new wrapped acked queue spec
colinsurprenant
added a commit
that referenced
this pull request
Jul 18, 2017
page test queue test move is_empty? at queue level new wrapped acked queue spec
|
merged in master, 5.x and 5.5 |
|
present in 5.5.2+ |
|
@seang-es if you mean fixed in 5.5.2+ then yes, the fixed was merged in the 5.5 branch and included starting with 5.5.2. Labels are missing here, I will label it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the second item of #7568 which aim at an acceptable fix to satisfy
ReadClient#empty?without changing the semantic ofQueue.isFullyAcked()The current implementation of
isFullyAcked()for both theQueueandPageclasses does not work to satisfy theReadClient#empty?condition, see #7570.