Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle malformed index patterns on role management pages #99918

Merged
merged 1 commit into from
May 13, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented May 12, 2021

Summary

Index patterns generally require a title, but it's technically possible to create one without a title (via import, for example). This updates the role management UI to be more resilient against these malformed index patterns.

To test:

  • Extract and then import the attached ndjson.zip file via Saved Objects Management
  • Attempt to visit the Create/Edit role screen
  • Ensure the page renders correctly. Prior to this change, the screen would fail to render altogether.

malformedIndexPattern.ndjson.zip

Resolves #55741

@legrego legrego added release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.13.1 labels May 12, 2021
@legrego legrego requested a review from a team as a code owner May 12, 2021 13:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 764.9KB 765.0KB +32.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
fleet 4 2 -2
globalSearch 4 2 -2
total -8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner self-requested a review May 13, 2021 14:19
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected, LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.13.1 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roles UI crashes when any index pattern is missing its title
4 participants