-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable selection of filter status 'All' on AddToCaseAction #99757
Disable selection of filter status 'All' on AddToCaseAction #99757
Conversation
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
2f8b3ad
to
d400452
Compare
d400452
to
e28ac78
Compare
e28ac78
to
80cb340
Compare
x-pack/plugins/cases/public/components/all_cases/all_cases_generic.tsx
Outdated
Show resolved
Hide resolved
Previously it was always picking 'open', but it wouldn't work when hiddenStatuses contains "open".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! I tested and it's working great. Thanks for the fix!
@machadoum any idea if the flaky test is related to the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@elasticmachine merge upstream |
@jonathan-buttner It doesn't look related because it failed before executing the code on my changes. The command that failed was "waitForAlertsPanelToBeLoaded". I did run cypress locally, and I could reproduce the flakiness both on my branch and on master. It seems that on some ocations the alert panel takes a very long time to load. Here you can see the console log in at the exact moment when the test fails:
|
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @machadoum |
Thanks for looking! Sounds good, feel free to merge, we can address the flaky test at a different time 👍 |
…99757) * Fix: Disable selection of filter status 'All' on AddToCaseAction * UI: Hide disabled statuses on AddToCaseAction * Refactor: Rename disabledStatuses to hiddenStatuses * Fix: Pick the first valid status for initialFilterOptions Previously it was always picking 'open', but it wouldn't work when hiddenStatuses contains "open". * Add missing test Co-authored-by: Kibana Machine <[email protected]>
…100123) * Fix: Disable selection of filter status 'All' on AddToCaseAction * UI: Hide disabled statuses on AddToCaseAction * Refactor: Rename disabledStatuses to hiddenStatuses * Fix: Pick the first valid status for initialFilterOptions Previously it was always picking 'open', but it wouldn't work when hiddenStatuses contains "open". * Add missing test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…99757) * Fix: Disable selection of filter status 'All' on AddToCaseAction * UI: Hide disabled statuses on AddToCaseAction * Refactor: Rename disabledStatuses to hiddenStatuses * Fix: Pick the first valid status for initialFilterOptions Previously it was always picking 'open', but it wouldn't work when hiddenStatuses contains "open". * Add missing test Co-authored-by: Kibana Machine <[email protected]>
Closes #98742 "User not able to select "Closed" from drop-down on adding alert to existing case modal"
Summary
Hide status "all" and "closed" from the dropdown.
Expected Result
User should not be able to add an alert to a closed case
Before:
initial state
dropdown
After
Initial state
dropdown
Checklist
Delete any items that are not applicable to this PR.