Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packages] Move @kbn/ace to Bazel #99129

Merged
merged 8 commits into from
May 6, 2021
Merged

[packages] Move @kbn/ace to Bazel #99129

merged 8 commits into from
May 6, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 3, 2021

Part of #69706

That PR moves the @kbn/ace into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels May 3, 2021
@jbudz jbudz requested a review from a team as a code owner May 3, 2021 21:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz requested a review from mistic May 3, 2021 21:06
@jbudz jbudz added the auto-backport Deprecated - use backport:version if exact versions are needed label May 3, 2021
mistic
mistic approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic mistic mentioned this pull request May 4, 2021
Closed
23 tasks
@alisonelizabeth
Copy link
Contributor

Hi @jbudz! Are there any specific steps I should take to test this?

@jbudz
Copy link
Member Author

jbudz commented May 6, 2021

@alisonelizabeth - I've been verifying bootstrap works and runtime usage loads as expected. There's two commands for development within the folder that can be tested too, yarn kbn build-bazel and yarn kbn watch-bazel

alisonelizabeth
alisonelizabeth approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified bootstrap locally and did a quick smoke test of Console (which imports @kbn/ace). Test failures appear unrelated to changes.

@jbudz jbudz enabled auto-merge (squash) May 6, 2021 18:39
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 896.4KB 904.1KB +7.7KB
fileDataVisualizer 1.0MB 1.0MB +7.7KB
ml 5.9MB 5.9MB +7.7KB
searchprofiler 645.3KB 653.0KB +7.7KB
stackAlerts 655.2KB 662.9KB +7.7KB
transform 910.8KB 918.5KB +7.7KB
triggersActionsUi 1.5MB 1.5MB +7.7KB
watcher 835.6KB 843.3KB +7.7KB
total +61.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit e4e5740 into elastic:master May 6, 2021
@kibanamachine kibanamachine mentioned this pull request May 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 6, 2021
@jbudz @kibanamachine
[packages] Move @kbn/ace to Bazel (elastic#99129)
3b4314a
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 6, 2021
@kibanamachine @jbudz
[packages] Move @kbn/ace to Bazel (#99129) (#99528)
da82bd5 
Co-authored-by: Jonathan Budzenski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @alisonelizabeth @kibanamachine @mistic