-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Migrate remaining context files from js to ts #99019
Conversation
@elasticmachine merge upstream |
src/plugins/discover/public/application/angular/context/api/anchor.ts
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/angular/context/api/anchor.ts
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/angular/context/query/actions.tsx
Show resolved
Hide resolved
Pinging @elastic/kibana-app (Team:KibanaApp) |
src/plugins/discover/public/application/angular/context/query_parameters/actions.ts
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/angular/context/query_parameters/actions.ts
Outdated
Show resolved
Hide resolved
…ts-migration # Conflicts: # src/plugins/discover/public/application/angular/context/query_parameters/actions.test.ts # src/plugins/discover/public/application/components/context_error_message/context_error_message.test.tsx # src/plugins/discover/public/application/components/context_error_message/context_error_message.tsx
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thx for cleaning this up 🧹 , great debut in Discover land! thx a lot!
* [Discover] migrate remaining context files from js to ts * [Discover] get rid of any types * [Discover] replace constants with enums, update imports * [Discover] use unknown instead of any, correct types * [Discover] skip any type for tests Co-authored-by: Kibana Machine <[email protected]>
…9457) * [Discover] migrate remaining context files from js to ts * [Discover] get rid of any types * [Discover] replace constants with enums, update imports * [Discover] use unknown instead of any, correct types * [Discover] skip any type for tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Part of #92573
Summary