Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Migrate remaining context files from js to ts #99019

Merged
merged 7 commits into from
May 6, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented May 3, 2021

Part of #92573

Summary

  • add remaining types for business logic of context app

@dimaanj dimaanj added the Feature:Discover Discover Application label May 3, 2021
@dimaanj dimaanj self-assigned this May 3, 2021
@dimaanj dimaanj changed the title [Discover] migrate remaining context files from js to ts [Discover] Migrate remaining context files from js to ts May 3, 2021
@dimaanj dimaanj requested a review from kertal May 3, 2021 11:03
@dimaanj
Copy link
Contributor Author

dimaanj commented May 3, 2021

@elasticmachine merge upstream

@dimaanj dimaanj marked this pull request as ready for review May 4, 2021 09:04
@dimaanj dimaanj requested a review from a team May 4, 2021 09:04
@dimaanj dimaanj added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dimaanj dimaanj added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.14.0 labels May 4, 2021
dimaanj added 3 commits May 4, 2021 16:01
…ts-migration

# Conflicts:
#	src/plugins/discover/public/application/angular/context/query_parameters/actions.test.ts
#	src/plugins/discover/public/application/components/context_error_message/context_error_message.test.tsx
#	src/plugins/discover/public/application/components/context_error_message/context_error_message.tsx
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 411.7KB 410.0KB -1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thx for cleaning this up 🧹 , great debut in Discover land! thx a lot!

@dimaanj dimaanj merged commit a5eb98d into elastic:master May 6, 2021
dimaanj added a commit to dimaanj/kibana that referenced this pull request May 6, 2021
* [Discover] migrate remaining context files from js to ts

* [Discover] get rid of any types

* [Discover] replace constants with enums, update imports

* [Discover] use unknown instead of any, correct types

* [Discover] skip any type for tests

Co-authored-by: Kibana Machine <[email protected]>
dimaanj added a commit that referenced this pull request May 6, 2021
…9457)

* [Discover] migrate remaining context files from js to ts

* [Discover] get rid of any types

* [Discover] replace constants with enums, update imports

* [Discover] use unknown instead of any, correct types

* [Discover] skip any type for tests

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants