chore(NA): moving @kbn/analytics into bazel #98917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
This comment has been minimized.
This comment has been minimized.
…ana into move-kbn-analytics-into-bazel
|
Pinging @elastic/kibana-operations (Team:Operations) |
This comment has been minimized.
This comment has been minimized.
Bamieh
approved these changes
Apr 30, 2021
jbudz
approved these changes
Apr 30, 2021
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
May 3, 2021
* chore(NA): moving @kbn/analytics into bazel * chore(NA): fix type check for package migration * chore(NA): fix type check for package migration * chore(NA): fix type check for package migration * chore(NA): separate type generating from server code Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-analytics/scripts/build.js
mistic
added a commit
that referenced
this pull request
May 3, 2021
* chore(NA): moving @kbn/analytics into bazel * chore(NA): fix type check for package migration * chore(NA): fix type check for package migration * chore(NA): fix type check for package migration * chore(NA): separate type generating from server code Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-analytics/scripts/build.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR moves the @kbn/analytics into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.