[Metrics UI] Unskip Inventory View Functional Test #98085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
changed the title
simianhacker
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
simianhacker
force-pushed
the
issue-75724-re-enable-home-page-functional-test
branch
from
8788968 to
239322c
Compare
|
@elasticmachine merge upstream |
neptunian
approved these changes
Apr 23, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Apr 30, 2021
Co-authored-by: Kibana Machine <[email protected]>
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Apr 30, 2021
Co-authored-by: Kibana Machine <[email protected]>
simianhacker
added a commit
that referenced
this pull request
Apr 30, 2021
* [Metrics UI] Unskip Home Page Functional Test (#98085) Co-authored-by: Kibana Machine <[email protected]> * Removing metric annomolies Co-authored-by: Kibana Machine <[email protected]>
simianhacker
added a commit
that referenced
this pull request
Apr 30, 2021
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
removed
the
backport missing
simianhacker
deleted the
issue-75724-re-enable-home-page-functional-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #75724 by removing the
skipstatement along with removing the flakey tests for checking telemetry. Checking to ensure telemetry is important but not at the expense of losing out on the end-to-end test for the homepage. I filed an issue to re-implement these tests in a more robust manner.I also took the opportunity to reorganize the functional tests some so it's easier to just run the
Metrics UItest by issuing the following command.