[APM] Service overview: Instances table metadata foldout #96467

cauemarcondes · 2021-04-07T17:39:18Z

closes #94412

cauemarcondes · 2021-04-13T17:48:53Z

@elasticmachine merge upstream

...app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.ts

elasticmachine · 2021-04-13T19:19:51Z

Pinging @elastic/apm-ui (Team:apm)

smith

Looks great!

formgeist · 2021-04-14T11:31:20Z

@cauemarcondes Looks great! Really some great new capabilities we're gaining with this. I noticed some minor visual nits around the table that I wanted to share...

Looks like the Actions button width is a bit off, so the icon appears off-center. Only noticed this when clicking the icon and popover shows and the focus state is enabled.

The height of the table rows is inconsistent, not sure why this is - compared to the Transactions table on the same page (which also has sparklines). I'd prefer this to follow the existing tables on the row height if that's possible.

…-table

… into apm-instances-table

cauemarcondes · 2021-04-14T20:33:33Z

Fixes:

formgeist

@cauemarcondes Thanks for making those changes! I found that the actions button icon still looks like a different size and the focus state is around the icon itself.

vs. the accordion button icon

Layout changes

I think one of the enhancements that was missing from the original issue was changing the layout so the two panels would be using column flex group setting to ensure that the instances table wouldn't just expand down aside the other viz panel, but you'd be able to keep the visualization on top instead. I've attempted to mock this in the UI;

This requires us to also set a fixed height (like the latency chart in the top) to 200 to avoid it taking up too much space. The new layout for this section will also help when you have a lot of instances mapped in the visualization especially when there's comparisons in there as well. I just simply changed the EuiFlexGroup direction to column.

Lastly, there's a missing tooltip on the filter action in the service, cloud, and orchestration info tables. The copy could just be "Filter by value".

formgeist · 2021-04-15T08:48:00Z

One more thing; we should show which column it's sorted by default (traffic).

cauemarcondes · 2021-04-15T15:38:12Z

Fixes:
Action button:

Table below chart:

Sort direction:

.../apm/public/components/app/service_overview/service_overview_instances_table/get_columns.tsx

sorenlouv · 2021-04-19T20:54:55Z

retest

…-table

kibanamachine · 2021-04-19T22:07:57Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 27a1b78
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

Build X-Pack Kibana

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes · 2021-04-20T11:05:29Z

@elasticmachine merge upstream

cauemarcondes · 2021-04-20T13:09:51Z

jenkins, retest this please

cauemarcondes · 2021-04-20T15:11:45Z

@elasticmachine merge upstream

cauemarcondes · 2021-04-20T17:03:50Z

@elasticmachine merge upstream

… into apm-instances-table

kibanamachine · 2021-04-20T21:22:10Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1577	1583	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.2MB	4.2MB	+17.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* shows instance details * shows instance details * shows instance details * shows instance details * shows instance details * adding api test * addressing PR comments * addressing PR comments * addressing PR comments * addressing PR comments * fixing ts issues * fixing ci * fixing api tests * fixing api test * fixing api test Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-04-20T22:29:51Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…7763) * shows instance details * shows instance details * shows instance details * shows instance details * shows instance details * adding api test * addressing PR comments * addressing PR comments * addressing PR comments * addressing PR comments * fixing ts issues * fixing ci * fixing api tests * fixing api test * fixing api test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]>

cauemarcondes · 2021-05-04T20:46:31Z

e2e added here #99098

sorenlouv · 2021-07-01T13:42:26Z

...app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.ts

+        .filter((section) => !isEmpty(section.actions))
+    )
+    .filter((sections) => !isEmpty(sections));
+}


@cauemarcondes This looks like duplication from https://github.com/elastic/kibana/blob/5d95e2e0cd59438e76e7a585eed7ac382f78b057/x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections.ts

Can we avoid that?

yes you are right, I refactored it here #104338

cauemarcondes added release_note:enhancement v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 7, 2021

cauemarcondes added 4 commits April 12, 2021 14:55

shows instance details

c0d8ec1

shows instance details

d67cabd

shows instance details

ac9f697

shows instance details

0d10116

cauemarcondes force-pushed the apm-instances-table branch from 8aead6e to 0d10116 Compare April 12, 2021 18:56

cauemarcondes added 2 commits April 12, 2021 17:27

shows instance details

2212420

adding api test

ddb4a74

cauemarcondes marked this pull request as ready for review April 13, 2021 17:48

cauemarcondes requested a review from a team as a code owner April 13, 2021 17:48

Merge branch 'master' into apm-instances-table

2f6d167

smith reviewed Apr 13, 2021

View reviewed changes

...app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.ts Outdated Show resolved Hide resolved

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Apr 13, 2021

smith approved these changes Apr 13, 2021

View reviewed changes

cauemarcondes added 3 commits April 14, 2021 14:45

Merge branch 'master' of github.com:elastic/kibana into apm-instances…

5581780

…-table

addressing PR comments

46b47d5

Merge branch 'apm-instances-table' of github.com:cauemarcondes/kibana…

0a8d347

… into apm-instances-table

cauemarcondes requested a review from formgeist April 14, 2021 20:33

formgeist requested changes Apr 15, 2021

View reviewed changes

cauemarcondes added 2 commits April 15, 2021 11:30

addressing PR comments

b0ccc4f

addressing PR comments

f692b88

formgeist reviewed Apr 19, 2021

View reviewed changes

.../apm/public/components/app/service_overview/service_overview_instances_table/get_columns.tsx Outdated Show resolved Hide resolved

cauemarcondes added 2 commits April 19, 2021 08:56

addressing PR comments

e5c25a5

fixing ts issues

3056216

Merge branch 'master' of github.com:elastic/kibana into apm-instances…

27a1b78

…-table

fixing ci

4533b33

sorenlouv added the apm:test-plan-7.13.0 label Apr 20, 2021

Merge branch 'master' into apm-instances-table

0595c30

Merge branch 'master' into apm-instances-table

db7d677

kibanamachine and others added 5 commits April 20, 2021 13:03

Merge branch 'master' into apm-instances-table

1ef9966

fixing api tests

8975c1f

Merge branch 'apm-instances-table' of github.com:cauemarcondes/kibana…

69ff52a

… into apm-instances-table

fixing api test

40a294b

fixing api test

119e220

cauemarcondes merged commit 6b70784 into elastic:master Apr 20, 2021

cauemarcondes deleted the apm-instances-table branch April 20, 2021 22:27

kibanamachine mentioned this pull request Apr 20, 2021

[7.x] [APM] Service overview: Instances table metadata foldout (#96467) #97763

Merged

ogupte self-assigned this May 10, 2021

ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021

sorenlouv reviewed Jul 1, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Service overview: Instances table metadata foldout #96467

[APM] Service overview: Instances table metadata foldout #96467

cauemarcondes commented Apr 7, 2021 •

edited

Loading

cauemarcondes commented Apr 13, 2021

elasticmachine commented Apr 13, 2021

smith left a comment

formgeist commented Apr 14, 2021

cauemarcondes commented Apr 14, 2021

formgeist left a comment

formgeist commented Apr 15, 2021

cauemarcondes commented Apr 15, 2021

sorenlouv commented Apr 19, 2021

kibanamachine commented Apr 19, 2021

cauemarcondes commented Apr 20, 2021

cauemarcondes commented Apr 20, 2021

cauemarcondes commented Apr 20, 2021

cauemarcondes commented Apr 20, 2021

kibanamachine commented Apr 20, 2021

kibanamachine commented Apr 20, 2021

cauemarcondes commented May 4, 2021

sorenlouv Jul 1, 2021

cauemarcondes Jul 5, 2021

[APM] Service overview: Instances table metadata foldout #96467

[APM] Service overview: Instances table metadata foldout #96467

Conversation

cauemarcondes commented Apr 7, 2021 • edited Loading

cauemarcondes commented Apr 13, 2021

elasticmachine commented Apr 13, 2021

smith left a comment

Choose a reason for hiding this comment

formgeist commented Apr 14, 2021

cauemarcondes commented Apr 14, 2021

formgeist left a comment

Choose a reason for hiding this comment

Layout changes

formgeist commented Apr 15, 2021

cauemarcondes commented Apr 15, 2021

sorenlouv commented Apr 19, 2021

kibanamachine commented Apr 19, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

cauemarcondes commented Apr 20, 2021

cauemarcondes commented Apr 20, 2021

cauemarcondes commented Apr 20, 2021

cauemarcondes commented Apr 20, 2021

kibanamachine commented Apr 20, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Apr 20, 2021

💚 Backport successful

cauemarcondes commented May 4, 2021

sorenlouv Jul 1, 2021

Choose a reason for hiding this comment

cauemarcondes Jul 5, 2021

Choose a reason for hiding this comment

cauemarcondes commented Apr 7, 2021 •

edited

Loading