Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollups] Update API integration test #96071

Merged
merged 1 commit into from
Apr 1, 2021
Merged

[Rollups] Update API integration test #96071

merged 1 commit into from
Apr 1, 2021

Conversation

alisonelizabeth
Copy link
Contributor

Fixes #96002

Change introduced by elastic/elasticsearch#69288.

As far as I understand, there aren't any changes needed to the rollups plugin itself. Note that _tier will now display in the Terms fields list in the rollups wizard.

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups failed-es-promotion v7.13.0 labels Apr 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth
alisonelizabeth commented Apr 1, 2021
View reviewed changes
x-pack/test/api_integration/apis/management/rollup/rollup.js
});
// '_doc_count' is an expected metadata field from ES
// Order is not guaranteed, so we assert against individual field names
['_doc_count', 'testTotalField'].forEach((numericField) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up to #82547

cjcenizal
cjcenizal approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thanks for fixing this!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 91b7770 into elastic:master Apr 1, 2021
@alisonelizabeth alisonelizabeth deleted the rollups/api_integration_test branch April 1, 2021 19:36
@alisonelizabeth alisonelizabeth mentioned this pull request Apr 1, 2021
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96071 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 5, 2021
@alisonelizabeth alisonelizabeth added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 5, 2021
@spalger spalger added auto-backport Deprecated - use backport:version if exact versions are needed v7.13.0 and removed backport:skip This commit does not require backporting labels Apr 7, 2021
@spalger
Copy link
Contributor

spalger commented Apr 7, 2021

Backporting this to 7.x now that the relevant ES pr was backported.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 7, 2021
@alisonelizabeth @kibanamachine
[Rollups] Update API integration test (elastic#96071)
7452036
@kibanamachine kibanamachine mentioned this pull request Apr 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #96508

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 8, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 13, 2021
kibanamachine added a commit that referenced this pull request Apr 13, 2021
@kibanamachine @alisonelizabeth @jloleysens
[7.x] [Rollups] Update API integration test (#96071) (#96508)
13c7885 
* [Rollups] Update API integration test (#96071)

* updated 7.x error handler

Co-authored-by: Alison Goryachev <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed failed-es-promotion Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@alisonelizabeth @elasticmachine @kibanamachine @spalger @cjcenizal