Add close button to localNavDropdowns. #9437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Timelion docs dropdown scroll only the table. - Make Timelion tutorial a fluid height, instead of fixed.
|
Is there a reason we are going away from the small "arrow up" icon at the bottom of the timepicker drop-down, like we had in 5.0? The former was consistent with other places we had icons to minimize sections of our UI, whereas the "x" is a new icon. Are we going to "x" in other places eventually as well? 5.0 This PR |
|
Thanks for pointing that out, @tbragin. I'll change it back to the arrow for consistency. |
|
thanks @cjcenizal -- i do like the arrow control better at the top! LGTM
|
This was referenced Dec 12, 2016
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Dec 13, 2016
Backports PR elastic#9437 **Commit 1:** Add close button to localNavDropdowns. - Make Timelion docs dropdown scroll only the table. - Make Timelion tutorial a fluid height, instead of fixed. * Original sha: f149a44 * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:15:50Z **Commit 2:** Use chevron for localDropdownCloseButton. * Original sha: e4c62eb * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:49:44Z
cjcenizal
pushed a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #9437 **Commit 1:** Add close button to localNavDropdowns. - Make Timelion docs dropdown scroll only the table. - Make Timelion tutorial a fluid height, instead of fixed. * Original sha: f149a44 * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:15:50Z **Commit 2:** Use chevron for localDropdownCloseButton. * Original sha: e4c62eb * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:49:44Z
cjcenizal
added a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #9437 **Commit 1:** Add close button to localNavDropdowns. - Make Timelion docs dropdown scroll only the table. - Make Timelion tutorial a fluid height, instead of fixed. * Original sha: f149a44 * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:15:50Z **Commit 2:** Use chevron for localDropdownCloseButton. * Original sha: e4c62eb * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:49:44Z
cjcenizal
pushed a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #9437 **Commit 1:** Add close button to localNavDropdowns. - Make Timelion docs dropdown scroll only the table. - Make Timelion tutorial a fluid height, instead of fixed. * Original sha: f149a44 * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:15:50Z **Commit 2:** Use chevron for localDropdownCloseButton. * Original sha: e4c62eb * Authored by CJ Cenizal <[email protected]> on 2016-12-10T00:49:44Z
tbragin
added
the
Team:Platform-Design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9381