[file_upload] move ml Importer classes to file_upload plugin #91559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
chore
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
|
Just wanted to comment to say I've done a first pass over the code and tested several files on the Maps side. No glaring errors and things appear to be working well! Still planning at least a second deeper dive, but overall nice work 👍 |
|
@elasticmachine merge upstream |
kindsun
reviewed
Feb 18, 2021
x-pack/plugins/file_upload/public/components/json_upload_and_parse.js
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
jgowdyelastic
approved these changes
Feb 19, 2021
kindsun
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Overall the Maps (GeoJSON) portion lgtm! This PR retains the parts we really want to keep: primarily the UI and parsing logic; and removes the parts we don't need and can easily share in a consolidated plugin: primarily indexing and chunking.
- Tested locally in chrome with various test GeoJSON files
- Code review
Nice work! 💯
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 22, 2021
…#91559) * [ml] move importer to file_upload plugin * move file_parse logic into GeoJsonImporter * move file_parser tests to geojson_importer tests * rename geo_json_clean_and_validate to geojson_clean_and_validate * replace file_upload import with Importer.import * simplify JsonIndexFilePicker props * tslint * i18n fixes and tslint fixes * update functional test to account for change in layer name * review feedback * dependency_cache review feedback Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 22, 2021
* master: Ability to filter alerts by string parameters (elastic#92036) [APM] Fix for flaky correlations API test (elastic#91673) (elastic#92094) [Enterprise Search] Migrate shared role mapping components (elastic#91723) [file_upload] move ml Importer classes to file_upload plugin (elastic#91559) [Discover] Always show the "hide missing fields" toggle (elastic#91889) v2 migrations should exit process on corrupt saved object document (elastic#91465) [ML] Data Frame Analytics exploration page: filters improvements (elastic#91748) [ML] Data Frame Analytics: Improved error handling for scatterplot matrix. (elastic#91993) [coverage] speed up merging results of functional tests (elastic#92111) Adds a Reason indicator to the onClose handler in AddAlert and EditAlert (elastic#92149)
nreese
added a commit
that referenced
this pull request
Feb 22, 2021
…#92213) * [ml] move importer to file_upload plugin * move file_parse logic into GeoJsonImporter * move file_parser tests to geojson_importer tests * rename geo_json_clean_and_validate to geojson_clean_and_validate * replace file_upload import with Importer.import * simplify JsonIndexFilePicker props * tslint * i18n fixes and tslint fixes * update functional test to account for change in layer name * review feedback * dependency_cache review feedback Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves ml Importer classes to file_upload plugin. The PR then refactors geojson upload into a GeoJsonImporter.