[Alerting] Allow user to select existing connector of same type when fixing broken connector #89062

ymao1 · 2021-01-22T18:20:50Z

Resolves #87533

Summary

Fixes the issue when you have an alert associated with a connector and that connector gets deleted, you are forced to create a new connector of the same type, even if there already exists another connector of the same type. This PR adds a dropdown selector in order to quickly switch the connector.

View when there exists one or more connectors of the same type as the deleted connector

View when there is no other connector of that type (only option is to add new connector)

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

…ing/broken-connector

mdefazio · 2021-01-25T15:13:55Z

Should this be a warning message? Can the alert be saved without making this edit? I wonder if we just use the invalid state of the dropdown to indicate the error and not have the callout in the connector accordion. But perhaps that depends on whether this can be saved with this unfixed.

Some thoughts on copy if we go the invalid state route:

I think we will then need a callout at the top of the alert itself, as well as an icon next to the name of the connector.

ymao1 · 2021-01-25T15:50:37Z

Should this be a warning message? Can the alert be saved without making this edit? I wonder if we just use the invalid state of the dropdown to indicate the error and not have the callout in the connector accordion. But perhaps that depends on whether this can be saved with this unfixed.

I think we will then need a callout at the top of the alert itself, as well as an icon next to the name of the connector.

@mdefazio The alert cannot be saved without either deleting or fixing the broken connector, so I think an error icon makes sense next to the name of the connector.

What about the case where there is no connector of the same type to select (second screenshot in the PR). Right now we don't show any dropdown, just the callout and a button to Create connector. Would you suggest any changes to that view?

mdefazio · 2021-01-25T16:51:47Z

Assuming it still makes sense to have an error icon next to the connector title, then I think we could keep the button (but remove the callout like we do in the first screenshot)

…ing/broken-connector

ymao1 · 2021-01-25T20:51:08Z

@mdefazio What do you think?

When no other connectors are available:

When other connectors are available:

I think the second screenshot might be a little aggressive, what do you think? In order to show the error message underneath the dropdown, I had to set isInvalid to true, which then turns the label above the dropdown red, so they are both red

mdefazio · 2021-01-26T12:47:55Z

I think it's ok they are both red. This is our invalid pattern so I think it's clear that it needs to be fixed.

…ing/broken-connector

ymao1 · 2021-01-26T19:51:10Z

I think it's ok they are both red. This is our invalid pattern so I think it's clear that it needs to be fixed.

@mdefazio Ok thanks! One last question:

When no other connectors are available, I've removed the callout and added the error icon with tooltip. Do you think that is enough differentiation between how it looks when you add a new action but need to add a connector for that action? In the screenshot below I have two broken connectors and 1 new action:

elasticmachine · 2021-01-26T21:32:39Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko

LGTM!

…ing/broken-connector

ymao1 · 2021-01-27T02:48:24Z

@elasticmachine merge upstream

mdefazio · 2021-01-27T02:54:02Z

If we're concerned the state where I've just added a connector is not different enough from the connector with nothing selected, we could show the 'Select a connector' dropdown (in default state), and when they open it can simply say "No connectors found". The user can then create a connector from this view as well. I see your concern though. We can also show the error text in the same location as 'No slack connectors' right?

…ing/broken-connector

…kibana into alerting/broken-connector

ymao1 · 2021-01-29T12:50:04Z

@elasticmachine merge upstream

ymao1 · 2021-02-01T13:57:14Z

@elasticmachine merge upstream

kibanamachine · 2021-02-01T15:38:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 28a92f8

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.4MB	+3.4KB

History

💛 Build #102117 was flaky b1e27b7
💚 Build #101472 succeeded 95b2aac
💚 Build #101339 succeeded a540f1f
💔 Build #101316 failed 79d12ac
💔 Build #101269 failed a1e69b4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris

LGTM 👍
Tested locally and it all looks great

…fixing broken connector (elastic#89062) * Adding dropdown for selecting different connector of same type * Updating design * Cleanup and i18n * Adding functiional test * Fixing unit test * Fixing functional test * Updating design Co-authored-by: Kibana Machine <[email protected]>

…fixing broken connector (#89062) (#90001) * Adding dropdown for selecting different connector of same type * Updating design * Cleanup and i18n * Adding functiional test * Fixing unit test * Fixing functional test * Updating design Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

…-ml-jobs * 'master' of github.com:elastic/kibana: (254 commits) [Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities (elastic#89927) Skip test for cloud (elastic#89450) [Fleet] Fix duplicate data streams being shown in UI (elastic#89812) Bump package dependencies (elastic#90034) [App Search] DRY helper for encoding/decoding routes that can have special characters in params (elastic#89811) TypeScript project references for Observability plugin (elastic#89320) [SearchSource] Combine sort and parent fields when serializing (elastic#89808) Made imports static (elastic#89935) [ml] migrate file_data_visualizer/import route to file_upload plugin (elastic#89640) [Discover] Adapt default column behavior (elastic#89826) Round start and end values (elastic#89030) Rename getProxyAgents to getCustomAgents (elastic#89813) [Form lib] UseField `onError` listener (elastic#89895) [APM] use latency sum instead of avg for impact (elastic#89990) migrate more core-owned plugins to tsproject ref (elastic#89975) [Logs UI] Load <LogStream> entries via async searches (elastic#86899) [APM] Abort browser requests when appropriate (elastic#89557) [Alerting] Allow user to select existing connector of same type when fixing broken connector (elastic#89062) [Data Table] Use shared CSV export mechanism (elastic#89702) chore(NA): improve logic check when installing Bazel tools (elastic#89634) ...

ymao1 added 2 commits January 21, 2021 13:06

Adding dropdown for selecting different connector of same type

fd5d71e

Merge branch 'master' of https://github.com/elastic/kibana into alert…

877d2ec

…ing/broken-connector

Merge branch 'master' of https://github.com/elastic/kibana into alert…

a724c4f

…ing/broken-connector

Updating design

47cfc1c

Merge branch 'master' of https://github.com/elastic/kibana into alert…

a9b5e7d

…ing/broken-connector

ymao1 added 2 commits January 26, 2021 14:55

Cleanup and i18n

cf77238

Adding functiional test

679423c

ymao1 self-assigned this Jan 26, 2021

ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0 labels Jan 26, 2021

Fixing unit test

a1e69b4

ymao1 marked this pull request as ready for review January 26, 2021 21:32

ymao1 requested a review from a team as a code owner January 26, 2021 21:32

YulNaumenko approved these changes Jan 26, 2021

View reviewed changes

ymao1 added 2 commits January 26, 2021 19:26

Merge branch 'master' of https://github.com/elastic/kibana into alert…

5f64fc3

…ing/broken-connector

Fixing functional test

79d12ac

Merge branch 'master' into alerting/broken-connector

a540f1f

Updating design

feabef9

ymao1 added 2 commits January 27, 2021 10:59

Merge branch 'master' of https://github.com/elastic/kibana into alert…

9b1004e

…ing/broken-connector

Merge branch 'alerting/broken-connector' of https://github.com/ymao1/…

95b2aac

…kibana into alerting/broken-connector

Merge branch 'master' into alerting/broken-connector

b1e27b7

Merge branch 'master' into alerting/broken-connector

28a92f8

gmmorris approved these changes Feb 2, 2021

View reviewed changes

ymao1 merged commit f3d7d37 into elastic:master Feb 2, 2021

ymao1 mentioned this pull request Feb 2, 2021

[7.x] [Alerting] Allow user to select existing connector of same type when fixing broken connector (#89062) #90001

Merged

mikecote added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Feb 2, 2021

ymao1 deleted the alerting/broken-connector branch March 25, 2021 14:43

ghost mentioned this pull request Mar 3, 2022

[Security Solution]Rule Action not able to perform after deletion of Rule Action Connector #126756

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] Allow user to select existing connector of same type when fixing broken connector #89062

[Alerting] Allow user to select existing connector of same type when fixing broken connector #89062

ymao1 commented Jan 22, 2021 •

edited

Loading

mdefazio commented Jan 25, 2021 •

edited

Loading

ymao1 commented Jan 25, 2021 •

edited

Loading

mdefazio commented Jan 25, 2021

ymao1 commented Jan 25, 2021

mdefazio commented Jan 26, 2021

ymao1 commented Jan 26, 2021

elasticmachine commented Jan 26, 2021

YulNaumenko left a comment

ymao1 commented Jan 27, 2021

mdefazio commented Jan 27, 2021

ymao1 commented Jan 29, 2021

ymao1 commented Feb 1, 2021

kibanamachine commented Feb 1, 2021

gmmorris left a comment

[Alerting] Allow user to select existing connector of same type when fixing broken connector #89062

[Alerting] Allow user to select existing connector of same type when fixing broken connector #89062

Conversation

ymao1 commented Jan 22, 2021 • edited Loading

Summary

View when there exists one or more connectors of the same type as the deleted connector

View when there is no other connector of that type (only option is to add new connector)

Checklist

mdefazio commented Jan 25, 2021 • edited Loading

ymao1 commented Jan 25, 2021 • edited Loading

mdefazio commented Jan 25, 2021

ymao1 commented Jan 25, 2021

mdefazio commented Jan 26, 2021

ymao1 commented Jan 26, 2021

elasticmachine commented Jan 26, 2021

YulNaumenko left a comment

Choose a reason for hiding this comment

ymao1 commented Jan 27, 2021

mdefazio commented Jan 27, 2021

ymao1 commented Jan 29, 2021

ymao1 commented Feb 1, 2021

kibanamachine commented Feb 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

gmmorris left a comment

Choose a reason for hiding this comment

ymao1 commented Jan 22, 2021 •

edited

Loading

mdefazio commented Jan 25, 2021 •

edited

Loading

ymao1 commented Jan 25, 2021 •

edited

Loading