Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.11] [Security Solution] Fixes elastic/kibana#84757 Use basePath in getAppOverviewUrl (#87245) #88754

Merged

Conversation

kqualters-elastic
Copy link
Contributor

…wUrl (elastic#87245)

* Use basePath in getAppOverviewUrl


Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

X-Pack EPM API Integration Tests.x-pack/test/fleet_api_integration/apis/agents/acks·ts.Fleet Endpoints fleet_agents_acks "before all" hook for "should return a 401 if this a not a valid acks access"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Fleet Endpoints
[00:00:00]           └-> "before all" hook
[00:01:22]           └-: fleet_agents_acks
[00:01:22]             └-> "before all" hook
[00:01:22]             └-> "before all" hook
[00:01:22]               │ info [fleet/agents] Loading "mappings.json"
[00:01:22]               │ info [fleet/agents] Loading "data.json"
[00:01:22]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2/CHLJn4E-T7aBi86VC2N_eQ] deleting index
[00:01:22]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1/SpaD0q8RTlupZrKw2YH02Q] deleting index
[00:01:22]               │ info [fleet/agents] Deleted existing index [".kibana_2",".kibana_1"]
[00:01:22]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:01:22]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]]).
[00:01:22]               │ info [fleet/agents] Created index ".kibana_1"
[00:01:22]               │ debg [fleet/agents] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1/nafL4I8ZQyiM-sXeNwLZUw] update_mapping [_doc]
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1/nafL4I8ZQyiM-sXeNwLZUw] update_mapping [_doc]
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1/nafL4I8ZQyiM-sXeNwLZUw] update_mapping [_doc]
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1/nafL4I8ZQyiM-sXeNwLZUw] update_mapping [_doc]
[00:01:22]               │ info [fleet/agents] Indexed 13 docs into ".kibana"
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_1/nafL4I8ZQyiM-sXeNwLZUw] update_mapping [_doc]
[00:01:22]               │ debg Migrating saved objects
[00:01:22]               │ proc [kibana]   log   [22:20:31.867] [info][savedobjects-service] Creating index .kibana_2.
[00:01:22]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:01:22]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] updating number_of_replicas to [0] for indices [.kibana_2]
[00:01:22]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]]).
[00:01:22]               │ proc [kibana]   log   [22:20:31.939] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2/y9_AjUvOTV-BrjMwX4nv1Q] update_mapping [_doc]
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2/y9_AjUvOTV-BrjMwX4nv1Q] update_mapping [_doc]
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2/y9_AjUvOTV-BrjMwX4nv1Q] update_mapping [_doc]
[00:01:22]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2/y9_AjUvOTV-BrjMwX4nv1Q] update_mapping [_doc]
[00:01:23]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1611089812783451030] [.kibana_2/y9_AjUvOTV-BrjMwX4nv1Q] update_mapping [_doc]
[00:01:23]               │ proc [kibana]   log   [22:20:32.227] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:01:23]               │ proc [kibana]   log   [22:20:32.276] [info][savedobjects-service] Finished in 411ms.
[00:01:23]               └- ✖ fail: Fleet Endpoints fleet_agents_acks "before all" hook for "should return a 401 if this a not a valid acks access"
[00:01:23]               │      ResponseError: version_conflict_engine_exception
[00:01:23]               │       at onBody (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
[00:01:23]               │       at IncomingMessage.onEnd (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
[00:01:23]               │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:01:23]               │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:01:23]               │ 
[00:01:23]               │ 

Stack Trace

ResponseError: version_conflict_engine_exception
    at onBody (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
    at IncomingMessage.onEnd (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  meta: {
    body: { error: [Object], status: 409 },
    statusCode: 409,
    headers: {
      warning: '299 Elasticsearch-7.11.0-SNAPSHOT-2474dcd0a4a895f6efad2b22d7d63b7f127619c2 "this request accesses system indices: [.kibana_2], but in a future major version, direct access to system indices will be prevented by default"',
      'content-type': 'application/json; charset=UTF-8',
      'content-length': '553'
    },
    meta: {
      context: null,
      request: [Object],
      name: 'elasticsearch-js',
      connection: [Object],
      attempts: 0,
      aborted: false
    }
  }
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +380.0B
triggersActionsUi 1.5MB 1.5MB -26.9KB
total -26.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.1KB 162.2KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit 8547670 into elastic:7.11 Jan 19, 2021
@kqualters-elastic kqualters-elastic deleted the backport/7.11/pr-87245 branch January 19, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants