Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding jobs stats to functions shared in setup contract #88673

Merged
merged 5 commits into from
Jan 25, 2021
Merged

[ML] Adding jobs stats to functions shared in setup contract #88673

merged 5 commits into from
Jan 25, 2021

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jan 19, 2021 •
edited
Loading

Adds functions to share getJobStats, getDatafeeds and getDatafeedStats via our setup contract.

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic self-assigned this Jan 21, 2021
@jgowdyelastic jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.12.0 v8.0.0 labels Jan 21, 2021
@jgowdyelastic jgowdyelastic marked this pull request as ready for review January 21, 2021 16:59
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner January 21, 2021 16:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Jan 21, 2021

LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

walterra
walterra approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - just need a refresher on that server side code, is error handling covered by the wrapping code (like ok() itself)?

@jgowdyelastic
Copy link
Member Author

Code LGTM - just need a refresher on that server side code, is error handling covered by the wrapping code (like ok() itself)?

All errors thrown from within ok are passed back to the caller of the function so they can handle them.
This is unlike our endpoints which wrap the errors in Boom objects and hide the possibly sensitive error bodies of 500 errors.

peteharverson
peteharverson approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit f15a1e6 into elastic:master Jan 25, 2021
@jgowdyelastic jgowdyelastic deleted the sharing-jobs-stats-in-setup-contract branch January 25, 2021 11:36
@jgowdyelastic jgowdyelastic mentioned this pull request Jan 25, 2021
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jan 25, 2021
@jgowdyelastic @kibanamachine
[ML] Adding jobs stats to functions shared in setup contract (elastic…
3288291 
…#88673)

* [ML] Adding jobs stats to functions shared in setup contract

* updating types

* adding datafeeds

Co-authored-by: Kibana Machine <[email protected]>
jgowdyelastic added a commit that referenced this pull request Jan 25, 2021
@jgowdyelastic @kibanamachine
[ML] Adding jobs stats to functions shared in setup contract (#88673) (…
acea647 
…#89118)

* [ML] Adding jobs stats to functions shared in setup contract

* updating types

* adding datafeeds

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @qn895 @kibanamachine @walterra @peteharverson