chore(NA): move watcher plugin tests out of __tests__ folder #87599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
@elastic/es-ui can I have your review here please? |
tylersmalley
reviewed
Jan 7, 2021
alisonelizabeth
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Thanks for working on this @mistic! I'm approving to unblock you, but I might suggest renaming the client_integration directory to client_integration_tests since it's no longer under __jest__. I think it might make it a little more clear that only test-related code resides under this directory.
I also created #87691 as a follow-up to address the tests that you found were out of date and skipped.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 7, 2021
…#87599) * chore(NA): move watcher plugin tests out of __tests__ folder * chore(NA): renaming client_integration into tests_client_integration * chore(NA): rename test helper config file Co-authored-by: Kibana Machine <[email protected]>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 7, 2021
…#87599) * chore(NA): move watcher plugin tests out of __tests__ folder * chore(NA): renaming client_integration into tests_client_integration * chore(NA): rename test helper config file Co-authored-by: Kibana Machine <[email protected]>
mistic
added a commit
that referenced
this pull request
Jan 8, 2021
…#87747) * chore(NA): move watcher plugin tests out of __tests__ folder * chore(NA): renaming client_integration into tests_client_integration * chore(NA): rename test helper config file Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
mistic
added a commit
that referenced
this pull request
Jan 8, 2021
…#87746) * chore(NA): move watcher plugin tests out of __tests__ folder * chore(NA): renaming client_integration into tests_client_integration * chore(NA): rename test helper config file Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves the second item of #85513 forward as it moves watcher tests out of tests folder into our common setup for tests run with jest.