Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution] Fixes elastic/kibana#84757 Use basePath in getAppOverviewUrl (#87245) #87559

Merged

Conversation

kqualters-elastic
Copy link
Contributor

…wUrl (elastic#87245)

* Use basePath in getAppOverviewUrl


Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

"before all" hook for "can open and close the modal".value lists management modal "before all" hook for "can open and close the modal"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/86982

Error: Timed out while retrying, last result was: {false}

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `management modal`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.completeOrRetry (http://localhost:6121/__cypress/tests?p=cypress/support/index.js:1414:13)

"before each" hook for "Does not allow a t1 analyst user to upload a value list".value lists user with restricted access role "before each" hook for "Does not allow a t1 analyst user to upload a value list"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/86983

AssertionError: Timed out retrying: Expected to find element: `[data-test-subj="headerGlobalNav"]`, but never found it.

Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `user with restricted access...`
    at Object.loginAndWaitForPageWithoutDateRange (http://localhost:6121/__cypress/tests?p=cypress/integration/value_lists.spec.ts:16205:8)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/value_lists.spec.ts:15238:21)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +380.0B

Distributable file count

id before after diff
default 47593 48356 +763

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kqualters-elastic kqualters-elastic merged commit 08daeff into elastic:7.x Jan 7, 2021
@kqualters-elastic kqualters-elastic deleted the backport/7.x/pr-87245 branch January 7, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants