Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fix ViewMode Updates from URL #87405

Merged
merged 3 commits into from
Jan 7, 2021
Merged

[Dashboard] Fix ViewMode Updates from URL #87405

merged 3 commits into from
Jan 7, 2021

Conversation

ThomThomson
Copy link
Contributor

Summary

Fixes #87403 by re-rendering dashboard top nav any time viewMode changes.

Jan-05-2021 17-56-20

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 5, 2021
@ThomThomson ThomThomson requested a review from a team as a code owner January 5, 2021 22:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 197.8KB 198.3KB +537.0B

Distributable file count

id before after diff
default 47260 48020 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as advertised

@ThomThomson ThomThomson merged commit b906b10 into elastic:master Jan 7, 2021
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Jan 7, 2021
@ThomThomson
[Dashboard] Fix ViewMode Updates from URL (elastic#87405)
5ea46d0 
* added view mode state into `use_dashboard_state_manager` to re-render dashboard top nav any time the viewMode changes
@ThomThomson ThomThomson mentioned this pull request Jan 7, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Jan 7, 2021
@ThomThomson
[Dashboard] Fix ViewMode Updates from URL (elastic#87405)
554ab70 
* added view mode state into `use_dashboard_state_manager` to re-render dashboard top nav any time the viewMode changes
@ThomThomson ThomThomson mentioned this pull request Jan 7, 2021
Merged
ThomThomson added a commit that referenced this pull request Jan 7, 2021
@ThomThomson
[Dashboard] Fix ViewMode Updates from URL (#87405) (#87679)
10d6b12 
* added view mode state into `use_dashboard_state_manager` to re-render dashboard top nav any time the viewMode changes
ThomThomson added a commit that referenced this pull request Jan 7, 2021
@ThomThomson
[Dashboard] Fix ViewMode Updates from URL (#87405) (#87678)
9d64b0f 
* added view mode state into `use_dashboard_state_manager` to re-render dashboard top nav any time the viewMode changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] View Mode Change From URL not Propagated to Top Nav
4 participants
@ThomThomson @elasticmachine @kibanamachine @poffdeluxe