Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Stop using constructor.name for logstash pipelines #87386

Merged
merged 5 commits into from
Jan 11, 2021
Merged

[Monitoring] Stop using constructor.name for logstash pipelines #87386

merged 5 commits into from
Jan 11, 2021

Conversation

chrisronline
Copy link
Contributor

Resolves #87156

@chrisronline chrisronline self-assigned this Jan 5, 2021
@chrisronline chrisronline requested a review from a team January 5, 2021 20:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor Author

@ycombinator I hate to bring you in, but you are the author of this file originally. Do you recall why constructor.name was used, instead of typeString?

@ycombinator
Copy link
Contributor

Do you recall why constructor.name was used, instead of typeString?

Wow, this was a couple years ago so I have no memory of this decision, sorry. Could it be that typeString came after this code that uses constructor.name was already written? At any rate, looking at the code it looks like it's just trying to figure out some way to create the correct Statement based on the type of vertex so using typeString seems okay to me.

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

igoristic
igoristic approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it with a Kibana build, and seems like the fix is working

Awesome job on discovering the issue and the solution 🏆

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@liza-mae
Copy link
Contributor

@chrisronline Will this fix #86339 ? If so, can we merge to try at the next BC coming out this week? Thanks!

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 979.8KB 979.8KB -17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit ff8d30b into elastic:master Jan 11, 2021
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 11, 2021
@chrisronline @kibanamachine
[Monitoring] Stop using constructor.name for logstash pipelines (elas…
96662d4 
…tic#87386)

* Use typeString instead

* Used wrong type string

Co-authored-by: Kibana Machine <[email protected]>
@chrisronline chrisronline mentioned this pull request Jan 11, 2021
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 11, 2021
@chrisronline @kibanamachine
[Monitoring] Stop using constructor.name for logstash pipelines (elas…
ec8a934 
…tic#87386)

* Use typeString instead

* Used wrong type string

Co-authored-by: Kibana Machine <[email protected]>
@chrisronline chrisronline mentioned this pull request Jan 11, 2021
Merged
@chrisronline chrisronline deleted the monitoring/constructor_name branch January 11, 2021 19:36
chrisronline added a commit that referenced this pull request Jan 11, 2021
@chrisronline @kibanamachine
[Monitoring] Stop using constructor.name for logstash pipelines (#87386…
40c5ebb 
…) (#87904)

* Use typeString instead

* Used wrong type string

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
chrisronline added a commit that referenced this pull request Jan 11, 2021
@chrisronline @kibanamachine
[Monitoring] Stop using constructor.name for logstash pipelines (#87386…
caf41d5 
…) (#87905)

* Use typeString instead

* Used wrong type string

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:fix review Team:Monitoring Stack Monitoring team v7.11.1 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Monitoring] Stop relying on constructor.name
6 participants
@chrisronline @elasticmachine @ycombinator @liza-mae @kibanamachine @igoristic