-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] API integration tests - stabilize saved objects endpoint tests #87288
[ML] API integration tests - stabilize saved objects endpoint tests #87288
Conversation
Pinging @elastic/ml-ui (:ml) |
Checking test stability in a flaky test runner job ... No ML failure in 50 runs (2 unrelated test failures in index management and audit log). |
Checking test stability again in a flaky test runner job ... no failure in 50 runs ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest edits LGTM
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Plugin Functional Tests.x-pack/test/plugin_functional/test_suites/resolver.Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expectedStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…lastic#87288) This PR stabilizes some saved objects endpoint tests by making sure a different order of objects in a response array is still accepted.
…lastic#87288) This PR stabilizes some saved objects endpoint tests by making sure a different order of objects in a response array is still accepted.
Summary
This PR stabilizes some saved objects endpoint tests by making sure a different order of objects in a response array is still accepted.
Additional details
The validation
expect.eql
"Checks if the obj sortof equals another" (quote from doc string), which includes a different order of items in an array, but it doesn't work well with nested objects. So in some cases we need to sort the objects in an array before comparison. In other cases it's enough to split response validation and check the values of the keys separately.Closes #87269