Use management.getTitle for import summary
#87285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
| @@ -443,6 +444,7 @@ describe('#importSavedObjectsFromStream', () => { | |||
| }); | |||
|
|
|||
| test('handles a mix of successes and errors and injects metadata', async () => { | |||
| // TODO | |||
There was a problem hiding this comment.
nit: The TODO might be easier to tackle if we give a brief description on what remains to be done in this test.
There was a problem hiding this comment.
Woups, that's the bookmark I use to keep track of where I am when taking a break 😅 . Will remove it
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jan 6, 2021
* fix import summary title * remove TODO
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jan 6, 2021
* fix import summary title * remove TODO
pgayvallet
added a commit
that referenced
this pull request
Jan 6, 2021
* fix import summary title * remove TODO
pgayvallet
added a commit
that referenced
this pull request
Jan 6, 2021
* fix import summary title * remove TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #87235
Retrieve the imported object titles using
management.getTitlefrom the SO type meta instead of just accessingattributes.titleChecklist