Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] fix multiple scrolls on waterfall view #87281

Merged
merged 5 commits into from
Jan 6, 2021
Merged

[Uptime] fix multiple scrolls on waterfall view #87281

merged 5 commits into from
Jan 6, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Resolves: #86308

fix multiple scrolls on waterfall view

waterfall will take all the height available and will scroll.

image

@shahzad31 shahzad31 requested a review from Kerry350 January 5, 2021 10:25
@shahzad31 shahzad31 marked this pull request as ready for review January 5, 2021 10:25
@shahzad31 shahzad31 requested a review from a team as a code owner January 5, 2021 10:25
@shahzad31 shahzad31 added v7.11.0 v7.12.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 5, 2021
@shahzad31 shahzad31 removed the request for review from Kerry350 January 5, 2021 10:28
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I haven't yet pulled it down to test yet, but I will soon. A few questions.

x-pack/plugins/uptime/public/components/monitor/synthetics/waterfall/components/styles.ts Outdated Show resolved Hide resolved
...plugins/uptime/public/components/monitor/synthetics/waterfall/components/waterfall_chart.tsx Show resolved Hide resolved
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke
dominiqueclarke reviewed Jan 5, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing double scrolling

Uptime.-.Kibana.mp4

@shahzad31
Copy link
Contributor Author

I'm still seeing double scrolling

that Help us improve callout at top is complicating things. let me see if i can find more dynamic solution.

dominiqueclarke
dominiqueclarke approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful! One small nit regarding the ref name.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.0MB 1.0MB +621.0B

Distributable file count

id before after diff
default 47252 48012 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 4b4d6a6 into elastic:master Jan 6, 2021
@shahzad31 shahzad31 deleted the waterfall-scroll branch January 6, 2021 17:17
@shahzad31 shahzad31 mentioned this pull request Jan 7, 2021
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jan 7, 2021
@shahzad31 @kibanamachine
[Uptime] fix multiple scrolls on waterfall view (elastic#87281)
fd04a82 
Co-authored-by: Kibana Machine <[email protected]>
@shahzad31 shahzad31 mentioned this pull request Jan 7, 2021
Merged
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jan 7, 2021
@shahzad31 @kibanamachine
[Uptime] fix multiple scrolls on waterfall view (elastic#87281)
700401a 
Co-authored-by: Kibana Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Jan 7, 2021
@shahzad31 @kibanamachine
[7.x] [Uptime] fix multiple scrolls on waterfall view (#87281) (#87662)
68e1f99 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Jan 7, 2021
@shahzad31 @kibanamachine
[7.11] [Uptime] fix multiple scrolls on waterfall view (#87281) (#87663)
51420b5 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] [Bug] Waterfall has double scroll with misplaced footer legend
4 participants
@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke