[Dashboard] Fix Missing Legacy Redirect

[ThomThomson]

Summary

Fixes #87181 by adding some missing BWC from the deangularization effort.

Adds a new component, DashboardNoMatch to the end of the dashboard router. It attempts to migrate legacy dashboard urls when the route is not recognized. Copied from similar logic in the visualize app.

Additionally adds a new functional test which covers this by testing a markdown link with legacy url redirecting from one dashboard to another.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[ThomThomson]

@elasticmachine merge upstream

[poffdeluxe]

lgtm

[poffdeluxe]

nit: idk if it's worth making the invalid route a link if it's invalid but not a big deal either way

[ThomThomson]

Hahah, yeah that's definitely true. I copied this from Visualize and didn't even look at that, but it seems weird that you can just keep refreshing the error by clicking the link. Will remove.

[kibanamachine]

💛 Build succeeded, but was flaky

• continuous-integration/kibana-ci/pull-request
• Commit: 1bdf71f
• Flaky suites:
  • xpack-kibana-ciGroup7

---

Test Failures

Chrome X-Pack UI Plugin Functional Tests.x-pack/test/plugin_functional/test_suites/resolver.Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Resolver test app
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ debg navigating to resolverTest url: http://localhost:6141/app/resolverTest
[00:00:00]             │ debg navigate to: http://localhost:6141/app/resolverTest
[00:00:00]             │ debg browser[INFO] http://localhost:6141/login?next=%2Fapp%2FresolverTest%3F_t%3D1609886518288 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:00]             │
[00:00:00]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:00]             │ debg ... sleep(700) start
[00:00:00]             │ debg ... sleep(700) end
[00:00:00]             │ debg returned from get, calling refresh
[00:00:01]             │ debg browser[INFO] http://localhost:6141/login?next=%2Fapp%2FresolverTest%3F_t%3D1609886518288 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:01]             │
[00:00:01]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:02]             │ debg currentUrl = http://localhost:6141/login?next=%2Fapp%2FresolverTest%3F_t%3D1609886518288
[00:00:02]             │          appUrl = http://localhost:6141/app/resolverTest
[00:00:02]             │ debg TestSubjects.find(kibanaChrome)
[00:00:02]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:03]             │ debg Found login page
[00:00:03]             │ debg TestSubjects.setValue(loginUsername, test_user)
[00:00:03]             │ debg TestSubjects.click(loginUsername)
[00:00:03]             │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:03]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1609881983476670554] [.ds-ilm-history-5-2021.01.05-000001] creating index, cause [initialize_data_stream], templates [ilm-history], shards [1]/[0]
[00:00:03]             │ info [o.e.c.m.MetadataCreateDataStreamService] [kibana-ci-immutable-debian-tests-xxl-1609881983476670554] adding data stream [ilm-history-5] with write index [.ds-ilm-history-5-2021.01.05-000001] and backing indices []
[00:00:03]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-debian-tests-xxl-1609881983476670554] moving index [.ds-ilm-history-5-2021.01.05-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:03]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1609881983476670554] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.ds-ilm-history-5-2021.01.05-000001][0]]])." previous.health="YELLOW" reason="shards started [[.ds-ilm-history-5-2021.01.05-000001][0]]"
[00:00:03]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-debian-tests-xxl-1609881983476670554] moving index [.ds-ilm-history-5-2021.01.05-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [ilm-history-ilm-policy]
[00:00:03]             │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-debian-tests-xxl-1609881983476670554] moving index [.ds-ilm-history-5-2021.01.05-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [ilm-history-ilm-policy]
[00:00:03]             │ debg TestSubjects.setValue(loginPassword, changeme)
[00:00:03]             │ debg TestSubjects.click(loginPassword)
[00:00:03]             │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:03]             │ debg TestSubjects.click(loginSubmit)
[00:00:03]             │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:03]             │ debg Find.waitForDeletedByCssSelector('.kibanaWelcomeLogo') with timeout=10000
[00:00:03]             │ proc [kibana]   log   [22:42:01.954] [info][plugins][routes][security] Logging in with provider "basic" (basic)
[00:00:04]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:04]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"] nav:not(.ng-hide)') with timeout=60000
[00:00:07]             │ debg browser[INFO] http://localhost:6141/app/resolverTest?_t=1609886518288 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:07]             │
[00:00:07]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:07]             │ debg browser[INFO] http://localhost:6141/app/resolverTest?_t=1609886525424 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:07]             │
[00:00:07]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:08]             │ debg Finished login process currentUrl = http://localhost:6141/app/resolverTest
[00:00:08]             │ debg ... sleep(501) start
[00:00:08]             │ debg ... sleep(501) end
[00:00:09]             │ debg in navigateTo url = http://localhost:6141/app/resolverTest
[00:00:09]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:09]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:11]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:12]             │ debg ======browser======== setWindowSize 3840 2400
[00:00:12]             │ debg ======browser======== actual initial screenshot size width=1200, height=800
[00:00:12]             │ debg ======browser======== actual second screenshot size width= 600, height=400
[00:00:12]             │ debg ======browser======== calculated values xBorder= 0, yBorder=0, xScaling=1, yScaling=1
[00:00:12]             │ debg ======browser======== setting browser size to 3840 x 2400
[00:00:14]             │ debg ======browser======== final screenshot size width=3840, height=2400
[00:00:14]           └-> renders at least one node
[00:00:14]             └-> "before each" hook: global before each
[00:00:14]             │ debg TestSubjects.exists(resolver:node)
[00:00:14]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:node"]') with timeout=120000
[00:00:14]             └- ✓ pass  (76ms) "Resolver test app renders at least one node"
[00:00:14]           └-> renders a node list
[00:00:14]             └-> "before each" hook: global before each
[00:00:14]             │ debg TestSubjects.exists(resolver:node-list)
[00:00:14]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:node-list"]') with timeout=120000
[00:00:14]             └- ✓ pass  (32ms) "Resolver test app renders a node list"
[00:00:14]           └-> renders at least one edge line
[00:00:14]             └-> "before each" hook: global before each
[00:00:14]             │ debg TestSubjects.exists(resolver:graph:edgeline)
[00:00:14]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:graph:edgeline"]') with timeout=120000
[00:00:14]             └- ✓ pass  (70ms) "Resolver test app renders at least one edge line"
[00:00:14]           └-> renders graph controls
[00:00:14]             └-> "before each" hook: global before each
[00:00:14]             │ debg TestSubjects.exists(resolver:graph-controls)
[00:00:14]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:graph-controls"]') with timeout=120000
[00:00:14]             └- ✓ pass  (26ms) "Resolver test app renders graph controls"
[00:00:14]           └-: when the user is interacting with the node with ID: origin
[00:00:14]             └-> "before all" hook
[00:00:40]           └-: when the user is interacting with the node with ID: secondChild
[00:00:40]             └-> "before all" hook
[00:00:40]             └-> should render as expected
[00:00:40]               └-> "before each" hook: global before each
[00:00:40]               └-> "before each" hook
[00:00:40]               │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:40]               │ debg compareAgainstBaseline
[00:00:40]               │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child.png"
[00:00:41]               │ debg comparePngs: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child.png vs /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/baseline/second_child.png
[00:00:41]               │ debg calculating diff pixels...
[00:00:41]               │ debg percent different: 0.046875
[00:00:41]               └- ✓ pass  (1.3s) "Resolver test app when the user is interacting with the node with ID: secondChild should render as expected"
[00:00:41]             └-: when the user hovers over the primary button
[00:00:41]               └-> "before all" hook
[00:00:41]               └-> should render as expected
[00:00:41]                 └-> "before each" hook: global before each
[00:00:41]                 └-> "before each" hook
[00:00:41]                 └-> "before each" hook
[00:00:41]                   │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:42]                 │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:42]                 │ debg compareAgainstBaseline
[00:00:42]                 │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_with_primary_button_hovered.png"
[00:00:43]                 │ debg comparePngs: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_with_primary_button_hovered.png vs /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/baseline/second_child_with_primary_button_hovered.png
[00:00:43]                 │ debg calculating diff pixels...
[00:00:43]                 │ debg percent different: 0.05201388888888889
[00:00:43]                 └- ✓ pass  (1.3s) "Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button should render as expected"
[00:00:43]               └-: when the user has clicked the primary button (which selects the node.)
[00:00:43]                 └-> "before all" hook
[00:00:43]                 └-> should render as expected
[00:00:43]                   └-> "before each" hook: global before each
[00:00:43]                   └-> "before each" hook
[00:00:43]                   └-> "before each" hook
[00:00:43]                     │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:43]                   └-> "before each" hook
[00:00:44]                   │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:44]                   │ debg compareAgainstBaseline
[00:00:44]                   │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_selected_with_primary_button_hovered.png"
[00:00:46]                   │ debg comparePngs: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_selected_with_primary_button_hovered.png vs /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/baseline/second_child_selected_with_primary_button_hovered.png
[00:00:46]                   │ debg calculating diff pixels...
[00:00:46]                   │ debg percent different: 0.09599537037037037
[00:00:46]                   │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/failure/Resolver test app when the user is interacting with the node with ID_ secondChild when the user hovers over the primary button when the user has clicked the primary button _which selects the node_ should render as expected.png"
[00:00:46]                   │ info Current URL is: http://localhost:6141/app/resolverTest?resolver-test=(panelParameters%3A(nodeID%3AsecondChild)%2CpanelView%3AnodeDetail)
[00:00:46]                   │ info Saving page source to: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/failure_debug/html/Resolver test app when the user is interacting with the node with ID_ secondChild when the user hovers over the primary button when the user has clicked the primary button _which selects the node_ should render as expected.html
[00:00:46]                   └- ✖ fail: Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected
[00:00:46]                   │      Error: expected 0.09599537037037037 to be below 0.09
[00:00:46]                   │       at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:100:11)
[00:00:46]                   │       at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:336:8)
[00:00:46]                   │       at Function.lessThan (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:531:15)
[00:00:46]                   │       at Context.<anonymous> (test/plugin_functional/test_suites/resolver/index.ts:119:23)
[00:00:46]                   │       at Object.apply (/dev/shm/workspace/parallel/4/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:00:46]                   │ 
[00:00:46]                   │ 

Stack Trace

Error: expected 0.09599537037037037 to be below 0.09
    at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:336:8)
    at Function.lessThan (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:531:15)
    at Context.<anonymous> (test/plugin_functional/test_suites/resolver/index.ts:119:23)
    at Object.apply (/dev/shm/workspace/parallel/4/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)

---

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dashboard	198	199	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	197.8KB	199.4KB	+1.6KB

Distributable file count

id	before	after	diff
default	47260	48020	+760

History

• 💚 Build #97103 succeeded 7ad1177
• 💔 Build #97023 failed bb25d71
• 💚 Build #96799 succeeded ffa988d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream