Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix sorting on unmapped fields in Timeline Events… #87241

Conversation

patrykkopycinski
Copy link
Contributor

… table

Summary

Fixes #87088

Reason: #82901

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Jan 4, 2021
@patrykkopycinski patrykkopycinski self-assigned this Jan 4, 2021
@patrykkopycinski patrykkopycinski requested review from a team as code owners January 4, 2021 21:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +768.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
siem-ui-timeline 90 91 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 1e7c3f8 into elastic:master Jan 11, 2021
XavierM added a commit to XavierM/kibana that referenced this pull request Jan 12, 2021
elastic#87241)

* [Security Solution] Fix sorting on unmapped fields in Timeline Events table

* set unmapped_type to the column type

* add missing types

* Update saved_object_mappings.ts

Co-authored-by: Xavier Mouligneau <[email protected]>
XavierM added a commit to XavierM/kibana that referenced this pull request Jan 12, 2021
elastic#87241)

* [Security Solution] Fix sorting on unmapped fields in Timeline Events table

* set unmapped_type to the column type

* add missing types

* Update saved_object_mappings.ts

Co-authored-by: Xavier Mouligneau <[email protected]>
@patrykkopycinski patrykkopycinski deleted the fix/timeline-events-sort-implicit-filtering branch January 12, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Event count is not preserved if sorting is done on empty columns under the timeline
4 participants