Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] show map saved objects in visualize listing page #87165

Merged
merged 6 commits into from
Jan 6, 2021
Merged

[Maps] show map saved objects in visualize listing page #87165

merged 6 commits into from
Jan 6, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 4, 2021

Fixes #82189

This PR adds appExtensions.visualizations to map visualize alias so map saved objects are displayed in visualize listing page.

Screen Shot 2021-01-04 at 8 14 57 AM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.12.0 labels Jan 4, 2021
@nreese nreese requested a review from thomasneirynck January 4, 2021 15:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from a team January 4, 2021 20:41
stratoula
stratoula approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement @nreese ❤️ Kibana app code LGTM. Tested it locally and my maps viz are depicted correctly. Link also works 👏

@nreese nreese removed the request for review from thomasneirynck January 6, 2021 13:34
@nreese
Copy link
Contributor Author

nreese commented Jan 6, 2021

@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement, thx!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB -12.0B

Distributable file count

id before after diff
default 47254 48017 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 152.8KB 153.5KB +782.0B
visualizations 169.2KB 169.3KB +130.0B
total +912.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit bd91c16 into elastic:master Jan 6, 2021
nreese added a commit to nreese/kibana that referenced this pull request Jan 6, 2021
@nreese @kibanamachine
[Maps] show map saved objects in visualize listing page (elastic#87165)
d21caf2 
* [Maps] show map saved objects in visualize listing page

* tslint

* tslint

* tslint fixes

Co-authored-by: Kibana Machine <[email protected]>
@nreese nreese mentioned this pull request Jan 6, 2021
Merged
nreese added a commit that referenced this pull request Jan 6, 2021
@nreese @kibanamachine
[Maps] show map saved objects in visualize listing page (#87165) (#87538
d440179 
)

* [Maps] show map saved objects in visualize listing page

* tslint

* tslint

* tslint fixes

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] show maps in visualize listing page
5 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck @stratoula