[Time to Visualize] Align Lens & Visualize Top nav Buttons & Behaviour

[ThomThomson]

Summary

Fixes #81246 by aligning the wording and behaviour of the top nav buttons between lens and visualize.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[ThomThomson]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[flash1293]

@elasticmachine merge upstream

[stratoula]

@elasticmachine merge upstream

[stratoula]

@ThomThomson I have seen something that is weird but has to do with the breadcrumbs PR. Sorry about that, I should have reported it there but I saw it now. I have the flag set to true and I create a Lens chart. Everything is fine. When I set the flag to false and edit the Lens viz I see the Visualize link in breadcrumb which works ok as it redirects me to the list. But when I go back to history then it redirects me to the Lens Create page and not to the edit lens page.

Is it something expected? (and ofc is irrelevant with this PR, I am just asking and if you feel that is sthg that should be fixed then I will create an issue)

[stratoula]

Much cleaner!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 5310d57

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visualize	131.6KB	131.7KB	+108.0B

History

• 💚 Build #97353 succeeded 3f8a9e3
• 💚 Build #96954 succeeded 6d5b15b
• 💚 Build #96669 succeeded 5355896
• 💚 Build #96267 succeeded 83cfa19
• 💔 Build #96227 failed e9dbe1b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[ThomThomson]

@stratoula

Is it something expected? (and ofc is irrelevant with this PR, I am just asking and if you feel that is sthg that should be fixed then I will create an issue)

What's happening here is that you are getting into an undefined state by editing a previously created by value visualization with the dashboard.allowByValueEmbeddables flag set to false. It seems to me that we should make this more transparent by throwing an error toast and redirecting to the visualize listing page any time there is value input but by value embeddables are not allowed.

It is probably worth raising an issue for this, even though it's a fairly unlikely edge case. Thanks for the review!

[stratoula]

I agree @ThomThomson. I will raise an issue. Thanx for explaining this.

[stratoula]

Code LGTM, tested it locally and it works fine 👏