[Lens]Test color syncing #86906
Merged
[Lens]Test color syncing #86906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this |
flash1293
added
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
wylieconlon
approved these changes
Jan 6, 2021
| await dashboardAddPanel.clickCreateNewLink(); | ||
| await dashboardAddPanel.clickVisType('lens'); | ||
| await PageObjects.header.waitUntilLoadingHasFinished(); | ||
| await PageObjects.lens.goToTimeRange(); |
There was a problem hiding this comment.
Is the time range cleared in between the previous page load and this one? I would have expected it to persist.
| await PageObjects.lens.save('vis2', true, true); | ||
| await PageObjects.header.waitUntilLoadingHasFinished(); | ||
| await elasticChart.setNewChartUiDebugFlag(true); | ||
| await PageObjects.lens.goToTimeRange(); |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Good catch @wylieconlon - cleaned that up |
flash1293
added a commit
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rudimentary functional test for the color syncing setting on dashboards.