[Security Solution][Case] Fix comment content when pushing alerts to external services #86812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
bug
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
stephmilovic
approved these changes
Jan 5, 2021
I agree about that. We have the same issue with the timeline links. Specifically for Jira, at the moment they do not fully support markdown as they have their own markup language. I opened this issue to keep track of it: #87440 |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Jan 6, 2021
…external services (elastic#86812) Co-authored-by: Kibana Machine <[email protected]>
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Jan 6, 2021
…external services (elastic#86812) Co-authored-by: Kibana Machine <[email protected]>
cnasikas
added a commit
that referenced
this pull request
Jan 6, 2021
…ts to external services (#86812) (#87441) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
cnasikas
added a commit
that referenced
this pull request
Jan 6, 2021
…rts to external services (#86812) (#87442) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment, comments are of two types:
userandalert. When a comment of typealertis being pushed to an external service the comment is being shown as an empty comment without content. This PR fixes this issue. It adds content to comments of typealert.Fixes: #86102
Checklist
Delete any items that are not applicable to this PR.
For maintainers