Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] term join limit #86491

Merged
merged 10 commits into from
Jan 6, 2021
Merged

[Maps] term join limit #86491

merged 10 commits into from
Jan 6, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 18, 2020

Fixes #71706

This PR adds some missing feature parity with region map - to limit the number of terms for term joins.

Users can configure "size" in the join expression UI. When migrating region map visualizations, the size is transferred as well.

Screen Shot 2020-12-18 at 10 24 42 AM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.12.0 labels Dec 18, 2020
@nreese nreese requested a review from a team as a code owner December 18, 2020 17:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Jan 4, 2021

@elasticmachine merge upstream

thomasneirynck
thomasneirynck reviewed Jan 4, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition. Especially useful if the domain is really well known. will be a meaningful performance boost.

Further down the line, we could even consider setting this explicitly based on the size of the "left source". e.g. if the left-source is EMS or a static ES-source (ie. an eS-source that is not time-based and dynamic filtering is turned off) than this number does not change.

src/plugins/region_map/public/get_deprecation_message.tsx Show resolved Hide resolved
x-pack/plugins/maps/common/constants.ts Outdated Show resolved Hide resolved
@nreese nreese requested a review from thomasneirynck January 4, 2021 21:09
@nreese
Copy link
Contributor Author

nreese commented Jan 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB +2.7KB

Distributable file count

id before after diff
default 47252 48012 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 152.8KB 152.8KB +40.0B
regionMap 44.4KB 44.4KB +57.0B
total +97.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, tested and works

@nreese nreese merged commit 8a0c8f3 into elastic:master Jan 6, 2021
@nreese nreese mentioned this pull request Jan 6, 2021
Merged
nreese added a commit to nreese/kibana that referenced this pull request Jan 6, 2021
@nreese @kibanamachine
[Maps] term join limit (elastic#86491)
ac4519a 
* [Maps] term join limit

* update region map migration to set size

* display size in join expression

* tslint

* update jest snapshots

* remove default size and just default to max buckets

* add size to sourceMeta so join data is re-requested on size change

* tslint

Co-authored-by: Kibana Machine <[email protected]>
nreese added a commit that referenced this pull request Jan 6, 2021
@nreese @kibanamachine
[Maps] term join limit (#86491) (#87507)
a26f20e 
* [Maps] term join limit

* update region map migration to set size

* display size in join expression

* tslint

* update jest snapshots

* remove default size and just default to max buckets

* add size to sourceMeta so join data is re-requested on size change

* tslint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Add size-limit to term-join metrics
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck