[ML] Fix error callout for Anomaly detection jobs using runtime_mappings #86407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qn895
added
bug
|
Pinging @elastic/ml-ui (:ml) |
| @@ -110,6 +110,16 @@ export function isSourceDataChartableForDetector(job: CombinedJob, detectorIndex | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // We also cannot plot the source data if they datafeed uses any field defined by runtime_mappings | |||
| const runtimeMappings = | |||
There was a problem hiding this comment.
a lot of this code is duplicated, it might be worth creating a hasRuntimeMappings function which returns a boolean which is used in both of these functions?
|
@elasticmachine merge upstream |
61 tasks
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Dec 22, 2020
…ngs (elastic#86407) Co-authored-by: Kibana Machine <[email protected]>
qn895
added a commit
to qn895/kibana
that referenced
this pull request
Dec 22, 2020
…ngs (elastic#86407) Co-authored-by: Kibana Machine <[email protected]>
qn895
added a commit
that referenced
this pull request
Dec 22, 2020
…_mappings (#86407) (#86816) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
qn895
added a commit
that referenced
this pull request
Dec 23, 2020
…e_mappings (#86407) (#86817) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues with the Anomaly explorer chart showing empty when the job uses a runtime field when model plot is not enabled. Changes include:
Checklist