[ML] Transforms: Support for missing_bucket in transform advanced pivot editor #85758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Tested and confirmed missing_bucket added in the JSON editor is present in the saved pivot config.
Can #83266 be closed, or are there potentially any other parameters which could be added to the pivot config which we don't currently support in the JSON editor?
|
I changed the PR description to not auto-close the issue so we can get this in and then follow up. |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Dec 14, 2020
…ot editor (elastic#85758) Adds support for missing_bucket with group-by configurations in the advanced editor for pivot configurations. Previously, the editor would allow you to add the setting, but it would be stripped from the config once the transform gets created.
This was referenced Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #83266.
Adds support for
missing_bucketwith group-by configurations in the advanced editor for pivot configurations.Previously, the editor would allow you to add the setting, but it would be stripped from the config once the transform gets created.
Checklist
For maintainers