Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Update read-only callouts from warning to info so they persist when dismissed #84904

Merged
merged 12 commits into from
Dec 15, 2020
Merged

[Security Solution][Detections] Update read-only callouts from warning to info so they persist when dismissed #84904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cb65567
Adjust the callout to be of type Info
banderror Dec 2, 2020
988d0b8
Store dismissal in local storage: the most straightforward implementa…
banderror Dec 4, 2020
ae36124
Store dismissal in local storage: refactored, reusable implementation
banderror Dec 9, 2020
9ca264f
Fix and skip (temporarily) unit tests
banderror Dec 10, 2020
2408222
Add a new user role: Reader (read-only user)
banderror Dec 14, 2020
56183bf
Add Cypress tests
banderror Dec 14, 2020
c295640
Clean up
banderror Dec 14, 2020
ebd3aa7
Clean up: move reusable callouts to public/common/components
banderror Dec 15, 2020
9094120
Clean up: remove skipped tests
banderror Dec 15, 2020
d161755
Clean up: rename and move concrete callouts to public/detections/comp…
banderror Dec 15, 2020
732211e
Clean up: adjust translations
banderror Dec 15, 2020
c99615b
Clean up tests
banderror Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adjust the callout to be of type Info
  • Loading branch information
@banderror
banderror committed Dec 15, 2020
commit cb655673b0d20fe6ee65300608e2e70c9e4a39ad
6 changes: 2 additions & 4 deletions .../plugins/security_solution/public/detections/components/no_write_alerts_callout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ const NoWriteAlertsCallOutComponent = () => {
const handleCallOut = useCallback(() => setShowCallOut(false), [setShowCallOut]);

return showCallOut ? (
<EuiCallOut title={i18n.NO_WRITE_ALERTS_CALLOUT_TITLE} color="warning" iconType="alert">
<EuiCallOut title={i18n.NO_WRITE_ALERTS_CALLOUT_TITLE} iconType="iInCircle">
<p>{i18n.NO_WRITE_ALERTS_CALLOUT_MSG}</p>
<EuiButton color="warning" onClick={handleCallOut}>
{i18n.DISMISS_CALLOUT}
</EuiButton>
<EuiButton onClick={handleCallOut}>{i18n.DISMISS_CALLOUT}</EuiButton>
</EuiCallOut>
) : null;
};
Expand Down
6 changes: 2 additions & 4 deletions .../plugins/security_solution/public/detections/components/rules/read_only_callout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ const ReadOnlyCallOutComponent = () => {
const handleCallOut = useCallback(() => setShowCallOut(false), [setShowCallOut]);

return showCallOut ? (
<EuiCallOut title={i18n.READ_ONLY_CALLOUT_TITLE} color="warning" iconType="alert">
<EuiCallOut title={i18n.READ_ONLY_CALLOUT_TITLE} iconType="iInCircle">
<p>{i18n.READ_ONLY_CALLOUT_MSG}</p>
<EuiButton color="warning" onClick={handleCallOut}>
{i18n.DISMISS_CALLOUT}
</EuiButton>
<EuiButton onClick={handleCallOut}>{i18n.DISMISS_CALLOUT}</EuiButton>
</EuiCallOut>
) : null;
};
Expand Down