Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Default Integration Policy Configuration section is only shown if no UI extension is registered #84534

Merged
merged 2 commits into from
Nov 30, 2020
Merged

[Fleet] Default Integration Policy Configuration section is only shown if no UI extension is registered #84534

merged 2 commits into from
Nov 30, 2020

Conversation

paul-tavares
Copy link
Contributor

Summary

On the Integration Policy Create and Edit forms, the default (out-of-box) configuration section is now only shown when there is no UI Extension registered for that Package. When one is registered, it is assumed to provide the necessary UI for configuring the integration policy.

In addition, the Endpoint specific logic for naming an Integration Policy has been removed from Fleet and moved to the Endpoint Fleet custom UI extension.

Closes #82482

NGINX shown with out-of-box default configuration section:

Screen Shot 2020-11-30 at 10 02 02 AM

NGINX shown with a custom UI extension if one was registered:

Screen Shot 2020-11-30 at 10 00 51 AM

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Nov 30, 2020
@paul-tavares paul-tavares self-assigned this Nov 30, 2020
@paul-tavares paul-tavares requested a review from a team as a code owner November 30, 2020 15:47
@paul-tavares paul-tavares requested a review from a team November 30, 2020 15:47
@paul-tavares paul-tavares requested a review from a team as a code owner November 30, 2020 15:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

nchaulet
nchaulet approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.1MB 1.1MB -266.0B
securitySolution 8.0MB 8.0MB +1.2KB
total +916.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@paul-tavares paul-tavares merged commit 7ba6c73 into elastic:master Nov 30, 2020
@paul-tavares paul-tavares deleted the task/fleet-82482-policy-edit-ui-extension branch November 30, 2020 19:17
@paul-tavares paul-tavares mentioned this pull request Nov 30, 2020
Merged
paul-tavares added a commit that referenced this pull request Nov 30, 2020
@paul-tavares
[Fleet] Default Integration Policy Configuration section is only show…
43c2433 
…n if no UI extension is registered (#84534) (#84573)

* Do not render out-of-box integration policy configuration step if a custom UI extension is registered
* Remove endpoint specific logic from fleet and move it to UI extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@parkiino parkiino parkiino approved these changes

Assignees

@paul-tavares paul-tavares

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@paul-tavares @elasticmachine @kibanamachine @nchaulet @parkiino