Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Make route tags required #83801

Merged
merged 1 commit into from
Nov 19, 2020
Merged

[APM] Make route tags required #83801

merged 1 commit into from
Nov 19, 2020

Conversation

sorenlouv
Copy link
Member

This PR makes tags on routes required to make sure they are explicitly added. This makes it easier when inspecting endpoints and knowing what permissions is required when calling it

@sorenlouv sorenlouv requested review from a team as code owners November 19, 2020 14:48
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added backport:skip This commit does not require backporting v7.11.0 labels Nov 19, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

X-Pack EPM API Integration Tests.x-pack/test/fleet_api_integration/apis/agents/complete_flow·ts.Fleet Endpoints fleet_agent_flow should work

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Fleet Endpoints
[00:00:00]           └-> "before all" hook
[00:01:28]           └-: fleet_agent_flow
[00:01:28]             └-> "before all" hook
[00:01:28]             └-> "before all" hook
[00:01:28]               │ info [empty_kibana] Loading "mappings.json"
[00:01:29]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_1/tQoJtEaKQLGBlovOZIz32A] deleting index
[00:01:29]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/jwJ7EwbnSUK23oULVeDx5g] deleting index
[00:01:29]               │ info [empty_kibana] Deleted existing index [".kibana_2",".kibana_1"]
[00:01:29]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:01:29]               │ info [empty_kibana] Created index ".kibana"
[00:01:29]               │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:01:29]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana/ZcIsHk6gQICYNtSlFYM90g] update_mapping [_doc]
[00:01:29]               │ debg Migrating saved objects
[00:01:29]               │ proc [kibana]   log   [16:04:24.851] [info][savedobjects-service] Creating index .kibana_2.
[00:01:29]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:01:29]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] updating number_of_replicas to [0] for indices [.kibana_2]
[00:01:29]               │ proc [kibana]   log   [16:04:24.912] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:01:29]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:01:29]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] updating number_of_replicas to [0] for indices [.kibana_1]
[00:01:29]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1]
[00:01:29]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] updating number_of_replicas to [0] for indices [.tasks]
[00:01:29]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] 6332 finished with response BulkByScrollResponse[took=2.4ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:01:29]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana/ZcIsHk6gQICYNtSlFYM90g] deleting index
[00:01:29]               │ proc [kibana]   log   [16:04:25.281] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:01:29]               │ proc [kibana]   log   [16:04:25.289] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:01:29]               │ proc [kibana]   log   [16:04:25.314] [info][savedobjects-service] Finished in 465ms.
[00:01:29]             └-> "before all" hook
[00:01:29]               │ proc [kibana]   log   [16:04:25.335] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:29]               │ proc [kibana]   log   [16:04:25.337] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:29]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:52936, url.original: /search?package=endpoint&internal=true&experimental=true
[00:01:29]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:52938, url.original: /search?package=system&internal=true&experimental=true
[00:01:29]               │ proc [kibana]   log   [16:04:25.358] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:29]               │ proc [kibana]   log   [16:04:25.361] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:29]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:52944, url.original: /search?package=system&internal=true&experimental=true
[00:01:29]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:52946, url.original: /search?package=endpoint&internal=true&experimental=true
[00:01:29]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:29]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:30]               │ proc [kibana]   log   [16:04:25.894] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:30]               │ proc [kibana]   log   [16:04:25.900] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:53020, url.original: /search?experimental=true
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:53018, url.original: /search?experimental=true
[00:01:30]               │ proc [kibana]   log   [16:04:25.921] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:30]               │ proc [kibana]   log   [16:04:25.922] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:30]               │ proc [kibana]   log   [16:04:25.924] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:30]               │ proc [kibana]   log   [16:04:25.925] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:53034, url.original: /package/system/0.5.3
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:53032, url.original: /package/endpoint/0.13.1
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:53030, url.original: /package/endpoint/0.13.1
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:25 source.ip: 172.17.0.1:53038, url.original: /package/system/0.5.3
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:26 source.ip: 172.17.0.1:53050, url.original: /package/system/0.5.3/
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:26 source.ip: 172.17.0.1:53048, url.original: /package/endpoint/0.13.1/
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:26 source.ip: 172.17.0.1:53054, url.original: /package/endpoint/0.13.1/
[00:01:30]               │ info [docker:registry] 2020/11/19 16:04:26 source.ip: 172.17.0.1:53056, url.original: /package/system/0.5.3/
[00:01:30]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:31]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:31]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:31]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:35]               │ proc [kibana]   log   [16:04:31.078] [info][ingestManager][plugins] Found previous transform references:
[00:01:35]               │ proc [kibana]  []
[00:01:35]               │ proc [kibana]   log   [16:04:31.079] [info][ingestManager][plugins] Deleting currently installed transform ids 
[00:01:35]               │ proc [kibana]   log   [16:04:31.087] [info][ingestManager][plugins] Found previous transform references:
[00:01:35]               │ proc [kibana]  []
[00:01:35]               │ proc [kibana]   log   [16:04:31.088] [info][ingestManager][plugins] Deleting currently installed transform ids 
[00:01:36]               │ proc [kibana]   log   [16:04:32.006] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:36]               │ info [docker:registry] 2020/11/19 16:04:32 source.ip: 172.17.0.1:53722, url.original: /search?package=system&internal=true&experimental=true
[00:01:36]               │ proc [kibana]   log   [16:04:32.026] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:36]               │ info [docker:registry] 2020/11/19 16:04:32 source.ip: 172.17.0.1:53730, url.original: /search?package=system&internal=true&experimental=true
[00:01:36]               │ proc [kibana]   log   [16:04:32.033] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:36]               │ info [docker:registry] 2020/11/19 16:04:32 source.ip: 172.17.0.1:53734, url.original: /package/system/0.5.3
[00:01:36]               │ info [docker:registry] 2020/11/19 16:04:32 source.ip: 172.17.0.1:53740, url.original: /package/system/0.5.3/
[00:01:36]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:38]               │ proc [kibana]   log   [16:04:34.053] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:38]               │ proc [kibana]   log   [16:04:34.054] [info][ingestManager][plugins] Custom registry url is an experimental feature and is unsupported.
[00:01:38]               │ info [docker:registry] 2020/11/19 16:04:34 source.ip: 172.17.0.1:53982, url.original: /search?package=system&internal=true&experimental=true
[00:01:38]               │ info [docker:registry] 2020/11/19 16:04:34 source.ip: 172.17.0.1:53984, url.original: /search?package=endpoint&internal=true&experimental=true
[00:01:38]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] updated role [fleet_enroll]
[00:01:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] updated user [fleet_enroll]
[00:01:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:40]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:41]             └-> should work
[00:01:41]               └-> "before each" hook: global before each
[00:01:41]               └-> "before each" hook: beforeSetupWithDockerRegistry
[00:01:41]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:44]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1605797321779550869] [.kibana_2/shcv6OflS0yOrPh5O9Zzlg] update_mapping [_doc]
[00:01:52]               │ proc [kibana]   log   [16:04:48.663] [error][data][elasticsearch] [version_conflict_engine_exception]: [fleet-agents:96d95374-9996-4d0e-8c09-686224dfba2e]: version conflict, required seqNo [99], primary term [1]. current document has seqNo [100] and primary term [1]
[00:01:52]               │ proc [kibana]   log   [16:04:48.665] [error][ingestManager][plugins] [fleet-agents:96d95374-9996-4d0e-8c09-686224dfba2e]: version conflict, required seqNo [99], primary term [1]. current document has seqNo [100] and primary term [1]: version_conflict_engine_exception
[00:01:53]               └- ✖ fail: Fleet Endpoints fleet_agent_flow should work
[00:01:53]               │      Error: expected 200 "OK", got 409 "Conflict"
[00:01:53]               │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
[00:01:53]               │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
[00:01:53]               │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
[00:01:53]               │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
[00:01:53]               │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
[00:01:53]               │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
[00:01:53]               │       at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
[00:01:53]               │       at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:01:53]               │       at endReadableNT (_stream_readable.js:1223:12)
[00:01:53]               │       at processTicksAndRejections (internal/process/task_queues.js:84:21)
[00:01:53]               │ 
[00:01:53]               │

Stack Trace

Error: expected 200 "OK", got 409 "Conflict"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
    at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
    at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (_stream_readable.js:1223:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Nov 19, 2020
@sorenlouv sorenlouv merged commit 3d0770f into elastic:master Nov 19, 2020
@sorenlouv sorenlouv deleted the apm-make-tags-required branch November 19, 2020 18:51
@sorenlouv sorenlouv mentioned this pull request Nov 19, 2020
Merged
sorenlouv added a commit that referenced this pull request Nov 19, 2020
@sorenlouv
[7.x] [APM] Make route tags required (#83801) (#83845)
8b3072b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sorenlouv @elasticmachine @kibanamachine @dgieselaar @shahzad31