Fix functional tests for Share UI. #8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
bug/fix-shared-links-functional-test
branch
from
7ee3392 to
2fb22ed
Compare
LeeDr
reviewed
Sep 14, 2016
| @@ -52,14 +52,14 @@ bdd.describe('shared links', function describeIndexTests() { | |||
|
|
|||
| bdd.describe('shared link', function () { | |||
| bdd.it('should show "Share a link" caption', function () { | |||
| var expectedCaption = 'Share a link'; | |||
| var expectedCaption = 'Share saved'; | |||
There was a problem hiding this comment.
I guess this is only tested against the static part of the message? I see the whole message as "Share saved search". I suppose that "search" part changes to visualization or dashboard.
LeeDr
reviewed
Sep 14, 2016
There was a problem hiding this comment.
It looks like you've fixed this test which shares an unsaved search "Share snapshot".
But new functionality was added to share a link of a saved search.
Can you add a test for the message shown in the unsaved search
"Please save this search to enable this sharing option."
And another test for a saved search to verify the link is there and some elements of it?
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 14, 2016
--------- **Commit 1:** Fix functional tests for Share UI. * Original sha: 2fb22ed * Authored by CJ Cenizal <[email protected]> on 2016-09-14T01:38:38Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 14, 2016
--------- **Commit 1:** Fix functional tests for Share UI. * Original sha: 2fb22ed * Authored by CJ Cenizal <[email protected]> on 2016-09-14T01:38:38Z
cjcenizal
added a commit
that referenced
this pull request
Sep 14, 2016
[backport] PR #8285 to 5.0 - Fix functional tests for Share UI.
cjcenizal
added a commit
that referenced
this pull request
Sep 14, 2016
[backport] PR #8285 to 5.x - Fix functional tests for Share UI.
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Fix functional tests for Share UI. * Original sha: 8e5935a2322a565b6f110fa8927b56b78ff4e4f2 [formerly 2fb22ed] * Authored by CJ Cenizal <[email protected]> on 2016-09-14T01:38:38Z Former-commit-id: fc7357b
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8285 to 5.x - Fix functional tests for Share UI. Former-commit-id: a2ddb45
delanni
pushed a commit
that referenced
this pull request
Feb 13, 2025
`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0) - Changed `EuiFieldText` styles to prioritize `disabled` styling over `readonly`. ([#8271](elastic/eui#8271)) - Added `plugs` and `web` glyphs to `EuiIcon` ([#8285](elastic/eui#8285)) - Update `title` on `EuiColorPalettePickerPaletteProps` to be optional ([#8289](elastic/eui#8289)) **Bug fixes** - Fixed an issue with EuiDataGrid with auto row height resulting in a table of 0 height ([#8251](elastic/eui#8251)) - Fixed `disabled` behavior of `EuiFieldText` to prevent input changes. ([#8271](elastic/eui#8271)) **Borealis changes** - [Visual Refresh] Provide hooks for color palette functions ([#8284](elastic/eui#8284)) - [Visual Refresh] Make Borealis default theme in EUI ([#8288](elastic/eui#8288)) --- As you can probably tell, there are plenty of updated tests and snapshots this time around. They are the result of the following: 1. We've updated the default theme in `@elastic/eui` v99.2.0 to Borealis, which led to kibana tests using `renderWithTheme`, `mountWithTheme`, and other utility functions that wrap the tested component in `<EuiThemeProvider>` to switch to the correct, new color values. With this change, all tests should now use Borealis, regardless of the testing framework or its configuration. 2. Because of the default theme change in EUI, some class name hash fragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`) regenerated. Most Borealis-related changes in this PR are test env only and have no impact on what users see when using Kibana. --------- Co-authored-by: Elastic Machine <[email protected]>
JoseLuisGJ
added a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 13, 2025
`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0) - Changed `EuiFieldText` styles to prioritize `disabled` styling over `readonly`. ([elastic#8271](elastic/eui#8271)) - Added `plugs` and `web` glyphs to `EuiIcon` ([elastic#8285](elastic/eui#8285)) - Update `title` on `EuiColorPalettePickerPaletteProps` to be optional ([elastic#8289](elastic/eui#8289)) **Bug fixes** - Fixed an issue with EuiDataGrid with auto row height resulting in a table of 0 height ([elastic#8251](elastic/eui#8251)) - Fixed `disabled` behavior of `EuiFieldText` to prevent input changes. ([elastic#8271](elastic/eui#8271)) **Borealis changes** - [Visual Refresh] Provide hooks for color palette functions ([elastic#8284](elastic/eui#8284)) - [Visual Refresh] Make Borealis default theme in EUI ([elastic#8288](elastic/eui#8288)) --- As you can probably tell, there are plenty of updated tests and snapshots this time around. They are the result of the following: 1. We've updated the default theme in `@elastic/eui` v99.2.0 to Borealis, which led to kibana tests using `renderWithTheme`, `mountWithTheme`, and other utility functions that wrap the tested component in `<EuiThemeProvider>` to switch to the correct, new color values. With this change, all tests should now use Borealis, regardless of the testing framework or its configuration. 2. Because of the default theme change in EUI, some class name hash fragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`) regenerated. Most Borealis-related changes in this PR are test env only and have no impact on what users see when using Kibana. --------- Co-authored-by: Elastic Machine <[email protected]> ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
tkajtoch
added a commit
to tkajtoch/kibana
that referenced
this pull request
Feb 13, 2025
`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0) - Changed `EuiFieldText` styles to prioritize `disabled` styling over `readonly`. ([elastic#8271](elastic/eui#8271)) - Added `plugs` and `web` glyphs to `EuiIcon` ([elastic#8285](elastic/eui#8285)) - Update `title` on `EuiColorPalettePickerPaletteProps` to be optional ([elastic#8289](elastic/eui#8289)) **Bug fixes** - Fixed an issue with EuiDataGrid with auto row height resulting in a table of 0 height ([elastic#8251](elastic/eui#8251)) - Fixed `disabled` behavior of `EuiFieldText` to prevent input changes. ([elastic#8271](elastic/eui#8271)) **Borealis changes** - [Visual Refresh] Provide hooks for color palette functions ([elastic#8284](elastic/eui#8284)) - [Visual Refresh] Make Borealis default theme in EUI ([elastic#8288](elastic/eui#8288)) --- As you can probably tell, there are plenty of updated tests and snapshots this time around. They are the result of the following: 1. We've updated the default theme in `@elastic/eui` v99.2.0 to Borealis, which led to kibana tests using `renderWithTheme`, `mountWithTheme`, and other utility functions that wrap the tested component in `<EuiThemeProvider>` to switch to the correct, new color values. With this change, all tests should now use Borealis, regardless of the testing framework or its configuration. 2. Because of the default theme change in EUI, some class name hash fragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`) regenerated. Most Borealis-related changes in this PR are test env only and have no impact on what users see when using Kibana. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit e5958a4) # Conflicts: # src/platform/packages/shared/kbn-unified-data-table/src/components/compare_documents/hooks/__snapshots__/use_comparison_css.test.ts.snap # x-pack/solutions/security/packages/kbn-securitysolution-exception-list-components/src/exception_item_card/conditions/entry_content/__snapshots__/entry_content.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/embeddables/__mocks__/mock.ts
tkajtoch
added a commit
that referenced
this pull request
Feb 14, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Upgrade EUI to v99.2.0-borealis.0 (#209690)](#209690) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tomasz Kajtoch","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T09:20:46Z","message":"Upgrade EUI to v99.2.0-borealis.0 (#209690)\n\n`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n---\n\n## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)\n\n- Changed `EuiFieldText` styles to prioritize `disabled` styling over\n`readonly`. ([#8271](https://github.com/elastic/eui/pull/8271))\n- Added `plugs` and `web` glyphs to `EuiIcon`\n([#8285](https://github.com/elastic/eui/pull/8285))\n- Update `title` on `EuiColorPalettePickerPaletteProps` to be optional\n([#8289](https://github.com/elastic/eui/pull/8289))\n\n**Bug fixes**\n\n- Fixed an issue with EuiDataGrid with auto row height resulting in a\ntable of 0 height ([#8251](https://github.com/elastic/eui/pull/8251))\n- Fixed `disabled` behavior of `EuiFieldText` to prevent input changes.\n([#8271](https://github.com/elastic/eui/pull/8271))\n\n**Borealis changes**\n\n- [Visual Refresh] Provide hooks for color palette functions\n([#8284](https://github.com/elastic/eui/pull/8284))\n- [Visual Refresh] Make Borealis default theme in EUI\n([#8288](https://github.com/elastic/eui/pull/8288))\n\n---\n\nAs you can probably tell, there are plenty of updated tests and\nsnapshots this time around. They are the result of the following:\n\n1. We've updated the default theme in `@elastic/eui` v99.2.0 to\nBorealis, which led to kibana tests using `renderWithTheme`,\n`mountWithTheme`, and other utility functions that wrap the tested\ncomponent in `<EuiThemeProvider>` to switch to the correct, new color\nvalues. With this change, all tests should now use Borealis, regardless\nof the testing framework or its configuration.\n2. Because of the default theme change in EUI, some class name hash\nfragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)\nregenerated.\n\nMost Borealis-related changes in this PR are test env only and have no\nimpact on what users see when using Kibana.\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e5958a47f302c69871310903caeebc69257f886a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0"],"title":"Upgrade EUI to v99.2.0-borealis.0","number":209690,"url":"https://github.com/elastic/kibana/pull/209690","mergeCommit":{"message":"Upgrade EUI to v99.2.0-borealis.0 (#209690)\n\n`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n---\n\n## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)\n\n- Changed `EuiFieldText` styles to prioritize `disabled` styling over\n`readonly`. ([#8271](https://github.com/elastic/eui/pull/8271))\n- Added `plugs` and `web` glyphs to `EuiIcon`\n([#8285](https://github.com/elastic/eui/pull/8285))\n- Update `title` on `EuiColorPalettePickerPaletteProps` to be optional\n([#8289](https://github.com/elastic/eui/pull/8289))\n\n**Bug fixes**\n\n- Fixed an issue with EuiDataGrid with auto row height resulting in a\ntable of 0 height ([#8251](https://github.com/elastic/eui/pull/8251))\n- Fixed `disabled` behavior of `EuiFieldText` to prevent input changes.\n([#8271](https://github.com/elastic/eui/pull/8271))\n\n**Borealis changes**\n\n- [Visual Refresh] Provide hooks for color palette functions\n([#8284](https://github.com/elastic/eui/pull/8284))\n- [Visual Refresh] Make Borealis default theme in EUI\n([#8288](https://github.com/elastic/eui/pull/8288))\n\n---\n\nAs you can probably tell, there are plenty of updated tests and\nsnapshots this time around. They are the result of the following:\n\n1. We've updated the default theme in `@elastic/eui` v99.2.0 to\nBorealis, which led to kibana tests using `renderWithTheme`,\n`mountWithTheme`, and other utility functions that wrap the tested\ncomponent in `<EuiThemeProvider>` to switch to the correct, new color\nvalues. With this change, all tests should now use Borealis, regardless\nof the testing framework or its configuration.\n2. Because of the default theme change in EUI, some class name hash\nfragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)\nregenerated.\n\nMost Borealis-related changes in this PR are test env only and have no\nimpact on what users see when using Kibana.\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e5958a47f302c69871310903caeebc69257f886a"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209690","number":209690,"mergeCommit":{"message":"Upgrade EUI to v99.2.0-borealis.0 (#209690)\n\n`99.1.0-borealis.0` ⏩ `99.2.0-borealis.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n---\n\n## [`v99.2.0`](https://github.com/elastic/eui/releases/v99.2.0)\n\n- Changed `EuiFieldText` styles to prioritize `disabled` styling over\n`readonly`. ([#8271](https://github.com/elastic/eui/pull/8271))\n- Added `plugs` and `web` glyphs to `EuiIcon`\n([#8285](https://github.com/elastic/eui/pull/8285))\n- Update `title` on `EuiColorPalettePickerPaletteProps` to be optional\n([#8289](https://github.com/elastic/eui/pull/8289))\n\n**Bug fixes**\n\n- Fixed an issue with EuiDataGrid with auto row height resulting in a\ntable of 0 height ([#8251](https://github.com/elastic/eui/pull/8251))\n- Fixed `disabled` behavior of `EuiFieldText` to prevent input changes.\n([#8271](https://github.com/elastic/eui/pull/8271))\n\n**Borealis changes**\n\n- [Visual Refresh] Provide hooks for color palette functions\n([#8284](https://github.com/elastic/eui/pull/8284))\n- [Visual Refresh] Make Borealis default theme in EUI\n([#8288](https://github.com/elastic/eui/pull/8288))\n\n---\n\nAs you can probably tell, there are plenty of updated tests and\nsnapshots this time around. They are the result of the following:\n\n1. We've updated the default theme in `@elastic/eui` v99.2.0 to\nBorealis, which led to kibana tests using `renderWithTheme`,\n`mountWithTheme`, and other utility functions that wrap the tested\ncomponent in `<EuiThemeProvider>` to switch to the correct, new color\nvalues. With this change, all tests should now use Borealis, regardless\nof the testing framework or its configuration.\n2. Because of the default theme change in EUI, some class name hash\nfragments (e.g., `css-`**`wprskz`**`-euiButtonIcon-xs-empty-primary`)\nregenerated.\n\nMost Borealis-related changes in this PR are test env only and have no\nimpact on what users see when using Kibana.\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"e5958a47f302c69871310903caeebc69257f886a"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.