Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] update glob to catch x-pack #80963

Merged
merged 2 commits into from
Oct 19, 2020
Merged

[i18n] update glob to catch x-pack #80963

merged 2 commits into from
Oct 19, 2020

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Oct 19, 2020

translationPaths no longer detects x-pack dir. Updated glob to start detecting all .i18nrc files again.

@Bamieh Bamieh added blocker v8.0.0 v7.10.0 v7.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 19, 2020
@Bamieh
Copy link
Member Author

Bamieh commented Oct 19, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh Bamieh merged commit 90a7a9c into elastic:master Oct 19, 2020
@Bamieh Bamieh deleted the i18n/update_glob branch October 19, 2020 14:06
This was referenced Oct 19, 2020
Merged
Merged
Bamieh added a commit to Bamieh/kibana that referenced this pull request Oct 19, 2020
@Bamieh @kibanamachine
[i18n] update glob to catch x-pack (elastic#80963)
e8f82ae 
Co-authored-by: Kibana Machine <[email protected]>
Bamieh added a commit that referenced this pull request Oct 19, 2020
@Bamieh @kibanamachine
[7.10] [i18n] update glob to catch x-pack (#80963) (#80989)
d85754d 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Bamieh added a commit that referenced this pull request Oct 19, 2020
@Bamieh @kibanamachine
[7.x] [i18n] update glob to catch x-pack (#80963) (#80988)
2b91953 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
blocker release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bamieh @kibanamachine @TinaHeiligers