Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Renamed 'positive rate' to 'counter rate' #80939

Merged
merged 3 commits into from
Oct 30, 2020
Merged

[TSVB] Renamed 'positive rate' to 'counter rate' #80939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
564d4e4
Renamed 'positive rate' label text to 'counter rate'
batchunag Oct 29, 2020
27fb0f2
Removed translations(ja-JP, zh-CN) where the labels were updated
batchunag Oct 29, 2020
703cc85
Merge branch 'master' into master
kibanamachine Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/vis_type_timeseries/common/agg_lookup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const lookup = {
}),
top_hit: i18n.translate('visTypeTimeseries.aggLookup.topHitLabel', { defaultMessage: 'Top Hit' }),
positive_rate: i18n.translate('visTypeTimeseries.aggLookup.positiveRateLabel', {
defaultMessage: 'Positive Rate',
defaultMessage: 'Counter Rate',
}),
};

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_type_timeseries/common/calculate_label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function calculateLabel(metric, metrics) {
}
if (metric.type === 'positive_rate') {
return i18n.translate('visTypeTimeseries.calculateLabel.positiveRateLabel', {
defaultMessage: 'Positive Rate of {field}',
defaultMessage: 'Counter Rate of {field}',
values: { field: metric.field },
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/vis_type_timeseries/public/application/components/aggs/agg_select.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('TSVB AggSelect', () => {
"value": "count",
},
Object {
"label": "Positive Rate",
"label": "Counter Rate",
"value": "positive_rate",
},
Object {
Expand Down Expand Up @@ -131,7 +131,7 @@ describe('TSVB AggSelect', () => {
"value": "filter_ratio",
},
Object {
"label": "Positive Rate",
"label": "Counter Rate",
"value": "positive_rate",
},
Object {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/vis_type_timeseries/public/application/components/aggs/agg_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const metricAggs: AggSelectOption[] = [
},
{
label: i18n.translate('visTypeTimeseries.aggSelect.metricsAggs.positiveRateLabel', {
defaultMessage: 'Positive Rate',
defaultMessage: 'Counter Rate',
}),
value: 'positive_rate',
},
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3801,7 +3801,6 @@
"visTypeTimeseries.aggLookup.percentileLabel": "パーセンタイル",
"visTypeTimeseries.aggLookup.percentileRankLabel": "パーセンタイルランク",
"visTypeTimeseries.aggLookup.positiveOnlyLabel": "プラスのみ",
"visTypeTimeseries.aggLookup.positiveRateLabel": "正の割合",
"visTypeTimeseries.aggLookup.serialDifferenceLabel": "連続差",
"visTypeTimeseries.aggLookup.seriesAggLabel": "数列集約",
"visTypeTimeseries.aggLookup.staticValueLabel": "不動値",
Expand All @@ -3824,7 +3823,6 @@
"visTypeTimeseries.aggSelect.metricsAggs.minLabel": "最低",
"visTypeTimeseries.aggSelect.metricsAggs.percentileLabel": "パーセンタイル",
"visTypeTimeseries.aggSelect.metricsAggs.percentileRankLabel": "パーセンタイルランク",
"visTypeTimeseries.aggSelect.metricsAggs.positiveRateLabel": "正の割合",
"visTypeTimeseries.aggSelect.metricsAggs.staticValueLabel": "不動値",
"visTypeTimeseries.aggSelect.metricsAggs.stdDeviationLabel": "標準偏差",
"visTypeTimeseries.aggSelect.metricsAggs.sumLabel": "合計",
Expand Down Expand Up @@ -3868,7 +3866,6 @@
"visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetLabel": "{targetLabel} 中 {lookupMetricType}",
"visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetWithAdditionalLabel": "{targetLabel} ({additionalLabel}) 中 {lookupMetricType}",
"visTypeTimeseries.calculateLabel.mathLabel": "数学処理",
"visTypeTimeseries.calculateLabel.positiveRateLabel": "{field}の正の割合",
"visTypeTimeseries.calculateLabel.seriesAggLabel": "数列集約 ({metricFunction})",
"visTypeTimeseries.calculateLabel.staticValueLabel": "{metricValue} の不動値",
"visTypeTimeseries.calculateLabel.unknownLabel": "不明",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3802,7 +3802,6 @@
"visTypeTimeseries.aggLookup.percentileLabel": "百分位数",
"visTypeTimeseries.aggLookup.percentileRankLabel": "百分位数排名",
"visTypeTimeseries.aggLookup.positiveOnlyLabel": "仅正数",
"visTypeTimeseries.aggLookup.positiveRateLabel": "正比率",
"visTypeTimeseries.aggLookup.serialDifferenceLabel": "串行差分",
"visTypeTimeseries.aggLookup.seriesAggLabel": "序列聚合",
"visTypeTimeseries.aggLookup.staticValueLabel": "静态值",
Expand All @@ -3825,7 +3824,6 @@
"visTypeTimeseries.aggSelect.metricsAggs.minLabel": "最小值",
"visTypeTimeseries.aggSelect.metricsAggs.percentileLabel": "百分位数",
"visTypeTimeseries.aggSelect.metricsAggs.percentileRankLabel": "百分位数排名",
"visTypeTimeseries.aggSelect.metricsAggs.positiveRateLabel": "正比率",
"visTypeTimeseries.aggSelect.metricsAggs.staticValueLabel": "静态值",
"visTypeTimeseries.aggSelect.metricsAggs.stdDeviationLabel": "标准偏差",
"visTypeTimeseries.aggSelect.metricsAggs.sumLabel": "和",
Expand Down Expand Up @@ -3869,7 +3867,6 @@
"visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetLabel": "{targetLabel} 的 {lookupMetricType}",
"visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetWithAdditionalLabel": "{targetLabel} ({additionalLabel}) 的 {lookupMetricType}",
"visTypeTimeseries.calculateLabel.mathLabel": "数学",
"visTypeTimeseries.calculateLabel.positiveRateLabel": "{field} 的正比率",
"visTypeTimeseries.calculateLabel.seriesAggLabel": "序列聚合 ({metricFunction})",
"visTypeTimeseries.calculateLabel.staticValueLabel": "{metricValue} 的静态值",
"visTypeTimeseries.calculateLabel.unknownLabel": "未知",
Expand Down