[Reporting] Config Schema Validation for rules[N].protocol strings #80766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:breaking
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
joelgriffith
approved these changes
Oct 15, 2020
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Oct 15, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 16, 2020
* master: (115 commits) [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618) added brace import to vis editor (elastic#80652) Fix error rate sorting in services list (elastic#80764) Emit info log when using custom registry URL (elastic#80768) [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766) Add Storybook a11y addon (elastic#80069) Fix anomaly alert selection text (elastic#80746) [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208) [kbn/optimizer] tweak split chunks options (elastic#80444) update template to use the new team label (elastic#80748) [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718) Adjusts observability alerting perms to require "all" (elastic#79896) [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists (elastic#80592) [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612) Licensed feature usage for connectors (elastic#77679) [Security Solution] Cypress template creation (elastic#80180) [APM] Hide service if only data is from ML (elastic#80145) Fix role mappings test for ESS (elastic#80604) [Maps] Add support for envelope (elastic#80614) [Security Solution] Update button text according to status (elastic#80389) ...
tsullivan
added a commit
that referenced
this pull request
Oct 16, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A Reporting Network Policy is a newly documented feature (separate PR), it's expected that more users will implement it in their config. Those who do so should have a safety measure against inputting
protocolstrings without an ending colon, which would be parsed correctly.This PR adds config schema validation to
xpack.reporting.capture.networkPolicy.rules[].protocol- it must end in colon.This PR is breaking, as Kibana will not start up after upgrading if a kibana.yml file has a protocol string that does match the new validation. Since this is a newly documented feature, that doesn't seem highly likely. On the other hand, this change is important for the new adopters in 7.x.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release Note
The Reporting plugin added new validation for
protocolstrings in Network Policy configurations. See "Restrict requests with a Reporting network policy" in the Kibana documentation. If thekibana.ymlhas a Reporting network policy before upgrade, the protocol strings must end with a colon. Otherwise, config validation will fail and Kibana will not start.