-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vega] user should be able to toggle "textTruncate" option for tooltips #80524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to truncate the text by default? I would have expected the default to show the full value with word-wrap: break-word
. What do you think about changing the defaults?
@wylieconlon not sure that I can answer for your question. This truncate logic was added in: #33465. My idea was to save all saved visualizations as it. @cchaos could you please help us to find the right solution from the UX perspective |
I think I agree with @wylieconlon, it should not be truncated by default and it should have a max width. In the above spec when the flag is false the tooltip width is quite big. So maybe we should have a max width and break the words on a new line. |
@wylieconlon @stratoula thank you, I've checked your proposal, it really looks much better. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is much better now 👏 LGTM!
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning truncation off by default is fine. What happens if that really long value didn't have spaces?
It still breaks to a new line @cchaos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Screenshots and code LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
…ps (elastic#80524) * [Vega] user should be able to override the default tooltip width Closes: elastic#80325 * fix jest * fix PR comments Co-authored-by: Kibana Machine <[email protected]>
…ps (#80524) (#80998) * [Vega] user should be able to override the default tooltip width Closes: #80325 * fix jest * fix PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Is this feature deprecated? I am running Kibana 7.10.2 and spec for testing shown above and the tooltip does not truncate. |
@brechun I see the PR was added in 7.11.0 |
Closes: #80325
Summary
New configuration property was added for
tooltips
Screens
textTruncate
istrue
:textTruncate
isfalse
(default value):Spec for testing