Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core UI] A11y tests for Kibana overview page #80285

Merged
merged 3 commits into from
Oct 13, 2020
Merged

[Core UI] A11y tests for Kibana overview page #80285

merged 3 commits into from
Oct 13, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 13, 2020

Summary

This adds a11y tests for the Kibana overview page.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added Project:Accessibility v8.0.0 release_note:skip Skip the PR/issue when compiling release notes REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.10.0 labels Oct 13, 2020
@cqliu1 cqliu1 requested a review from myasonik October 13, 2020 04:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

myasonik
myasonik approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@cqliu1
Copy link
Contributor Author

cqliu1 commented Oct 13, 2020

@elasticmachine merge upstream

@cqliu1 cqliu1 closed this Oct 13, 2020
@cqliu1 cqliu1 reopened this Oct 13, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 240fddc into elastic:master Oct 13, 2020
@cqliu1 cqliu1 deleted the a11y/kibana-overview-tests branch October 13, 2020 20:07
@cqliu1 cqliu1 mentioned this pull request Oct 15, 2020
Closed
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 15, 2020
@cqliu1
[Core UI] A11y tests for Kibana overview page (elastic#80285)
ab48b90 
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/accessibility/config.ts
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 15, 2020
@cqliu1
[Core UI] A11y tests for Kibana overview page (elastic#80285)
0f34717 
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/accessibility/config.ts
@cqliu1 cqliu1 mentioned this pull request Oct 15, 2020
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Oct 15, 2020
@cqliu1 @kibanamachine
[Core UI] A11y tests for Kibana overview page (elastic#80285)
a56b308 
Co-authored-by: Kibana Machine <[email protected]>
@cqliu1 cqliu1 mentioned this pull request Oct 15, 2020
Merged
cqliu1 added a commit that referenced this pull request Oct 15, 2020
@cqliu1
[Core UI] A11y tests for Kibana overview page (#80285) (#80696)
dcbab30 
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/accessibility/config.ts
cqliu1 added a commit that referenced this pull request Oct 15, 2020
@cqliu1 @kibanamachine
[7.10] [Core UI] A11y tests for Kibana overview page (#80285) (#80698)
5bd4eb8 
Co-authored-by: Kibana Machine <[email protected]>
@cqliu1 cqliu1 added the v7.11.0 label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

Assignees
No one assigned
Labels
Project:Accessibility REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cqliu1 @elasticmachine @kibanamachine @myasonik