Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Fix EC2 Query to only include aws.ec2 nodes #78236

Merged
merged 3 commits into from
Sep 23, 2020
Merged

[Metrics UI] Fix EC2 Query to only include aws.ec2 nodes #78236

merged 3 commits into from
Sep 23, 2020

Conversation

simianhacker
Copy link
Member

Summary

This PR fixes a bug where hosts where the cloud.instance.id would show up regardless of being an AWS EC2 instance or not. This simply adds a filter for event.dataset: aws.ec2.

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 23, 2020
@simianhacker simianhacker requested a review from a team as a code owner September 23, 2020 00:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Zacqary
Zacqary approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 4.2MB +144.0B 4.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit ca27ec8 into elastic:master Sep 23, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78236 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 25, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78236 or prevent reminders by adding the backport:skip label.

simianhacker added a commit to simianhacker/kibana that referenced this pull request Sep 29, 2020
@simianhacker
[Metrics UI] Fix EC2 Query to only include aws.ec2 nodes (elastic#78236)
c259174 
* [Metrics UI] Fix EC2 Query to only include aws.ec2 nodes

* Making the filter more generic so we can apply it easily to any inventory model
@simianhacker simianhacker mentioned this pull request Sep 29, 2020
Merged
simianhacker added a commit that referenced this pull request Sep 29, 2020
@simianhacker
[Metrics UI] Fix EC2 Query to only include aws.ec2 nodes (#78236) (#7…
9020e79 
…8859)

* [Metrics UI] Fix EC2 Query to only include aws.ec2 nodes

* Making the filter more generic so we can apply it easily to any inventory model
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 29, 2020
@simianhacker simianhacker mentioned this pull request Nov 12, 2021
Closed
@simianhacker simianhacker deleted the fix-ec2-for-snapshot branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simianhacker @elasticmachine @kibanamachine @Zacqary