[backport] PR #7724 to 4.5 - Elastic Tile Service and configurable leaflet providers #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epixa
changed the title
epixa
force-pushed
the
jasper/backport/7724/7779/4.5
branch
from
6138248 to
9982f2f
Compare
--------- **Commit 1:** [viz] Allow for configurable map urls * Original sha: 58844a0 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-12T21:29:00Z **Commit 2:** Adds every config option from Leaflet * Original sha: 0b9388c * Authored by Chris Earle <[email protected]> on 2016-07-13T00:31:04Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 3:** Removed confusing config options * Original sha: b1f8ac8 * Authored by Chris Earle <[email protected]> on 2016-07-13T01:07:01Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 4:** [vis] Don't rewrite markdown * Original sha: c670a1c * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:52:39Z **Commit 5:** [config] Update default tile link * Original sha: 7c8ec75 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:55:16Z **Commit 6:** Change bounds from object to GeoJSON (long, lat) array style * Original sha: 6d8f803 * Authored by Chris Earle <[email protected]> on 2016-07-13T02:58:07Z **Commit 7:** [config] Set max zoom to 7 * Original sha: b762949 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T03:07:47Z **Commit 8:** [tests] Cleanup schema data * Original sha: c3d203f * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T04:04:04Z **Commit 9:** [vis] Bound tilemap zoom * Original sha: 3c1339e * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T15:25:16Z **Commit 10:** Round out support for the initial Elastic Tile Service Correct links, legacy config handling, and wms server conditionals. * Original sha: 41fbb06 * Authored by Court Ewing <[email protected]> on 2016-07-15T20:50:47Z **Commit 11:** Made minZoom in test fixture consistent with reality * Original sha: 6494caa * Authored by Court Ewing <[email protected]> on 2016-07-15T21:11:36Z **Commit 12:** Correctly check for enabled wms to determine zoom Without this defensive check, a JS console error is thrown whenever wms is not configured for a map visualization. * Original sha: c74041c * Authored by Court Ewing <[email protected]> on 2016-07-15T21:15:10Z **Commit 13:** Remove duplicate wms conditional in tilemap createmap This separation made sense in the original implementation, but it is not necessary in this version. * Original sha: ca5a968 * Authored by Court Ewing <[email protected]> on 2016-07-15T21:35:21Z **Commit 14:** Remove optional joi references in tilemap config In joi, configurations are optional by default, so there's no need to be explicit here. * Original sha: 2feac11 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:34:38Z **Commit 15:** Re-disable scroll wheel zoom on maps Enabling scroll wheel search does not seem necessary in the context of this overall bug fix. * Original sha: 2862f94 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:39:40Z
epixa
force-pushed
the
jasper/backport/7724/7779/4.5
branch
from
9982f2f to
38b0117
Compare
This was referenced Jul 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #7724
Commit 1:
[viz] Allow for configurable map urls
Commit 2:
Adds every config option from Leaflet
Commit 3:
Removed confusing config options
Commit 4:
[vis] Don't rewrite markdown
Commit 5:
[config] Update default tile link
Commit 6:
Change bounds from object to GeoJSON (long, lat) array style
Commit 7:
[config] Set max zoom to 7
Commit 8:
[tests] Cleanup schema data
Commit 9:
[vis] Bound tilemap zoom
Commit 10:
Round out support for the initial Elastic Tile Service
Correct links, legacy config handling, and wms server conditionals.
Commit 11:
Made minZoom in test fixture consistent with reality
Commit 12:
Correctly check for enabled wms to determine zoom
Without this defensive check, a JS console error is thrown whenever wms
is not configured for a map visualization.
Commit 13:
Remove duplicate wms conditional in tilemap createmap
This separation made sense in the original implementation, but it is not
necessary in this version.
Commit 14:
Remove optional joi references in tilemap config
In joi, configurations are optional by default, so there's no need to be
explicit here.
Commit 15:
Re-disable scroll wheel zoom on maps
Enabling scroll wheel search does not seem necessary in the context of
this overall bug fix.
Backported based on diff from PR #7779