[ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists #77566

qn895 · 2020-09-16T00:27:25Z

Summary

This PR adds functional test for the calendar and filter list. It also updates the delete modal when deleting calendar(s).

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-09-16T00:27:27Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/ml/public/application/settings/calendars/edit/new_event_modal/new_event_modal.js

.../ml/public/application/settings/filter_lists/components/add_item_popover/add_item_popover.js

x-pack/plugins/ml/public/application/settings/filter_lists/edit/edit_filter_list.js

x-pack/test/functional/apps/ml/index.ts

x-pack/test/functional/services/ml/navigation.ts

…rlist-tests

peteharverson · 2020-09-17T09:04:54Z

config/kibana.yml

@@ -40,8 +40,8 @@
 # the username and password that the Kibana server uses to perform maintenance on the Kibana
 # index at startup. Your Kibana users still need to authenticate with Elasticsearch, which
 # is proxied through the Kibana server.
-#elasticsearch.username: "kibana_system"
-#elasticsearch.password: "pass"
+elasticsearch.username: "kibana_system"


You must remove these edits before merging!

This is why we added a codeowner on this file actually 😄 . Once reverted, you can remove the review request from the platform team.

Thanks @pgayvallet - I have reverted the change and removed review request. Sorry about that.

x-pack/test/functional/services/ml/settings_calendar.ts

…emButton, update snapshots, add more assertions

x-pack/test/functional/apps/ml/settings/calendar_creation.ts

x-pack/test/functional/apps/ml/settings/filter_list_edit.ts

…lidation for post edit

…rlist-tests # Conflicts: # x-pack/plugins/ml/public/application/settings/filter_lists/edit/edit_filter_list.js # x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js # x-pack/test/functional/services/ml/settings_filter_list.ts

qn895 · 2020-09-17T23:00:37Z

@elasticmachine merge upstream

pheyos

Functional test code LGTM with a few last comments.

pheyos · 2020-09-18T09:12:00Z

x-pack/test/functional/services/ml/settings_calendar.ts

@@ -124,7 +124,7 @@ export function MachineLearningSettingsCalendarProvider(
      await testSubjects.existOrFail('mlPageCalendarEdit');
    },

-    async assertApplyToAllJobsSwitchEnabled(expectedValue: boolean) {
+    async assertApplyToAllJobsSwitchCheckedState(expectedValue: boolean) {


This method is not validating the checked state, but rather that the control is enabled or disabled for the user, i.e. the user is able to toggle it vs the control is grayed out. So I think this change should be reverted. If you still think that the old method name is misleading, I'm open for other suggestions.

My apologies. I switched it back here db1bdd7

pheyos · 2020-09-18T09:17:16Z

x-pack/test/functional/services/ml/settings_calendar.ts

+      await this.assertCalendarEventDescriptionValue(eventDescription);
+    },
+
+    async createNewCalendarEvent(eventDescription: string) {


As discussed on slack: I think we don't need this method any more.

Removed here db1bdd7

pheyos · 2020-09-18T10:17:04Z

x-pack/test/functional/apps/ml/settings/filter_list_creation.ts

-        await ml.settingsFilterList.saveFilterList();
-        await ml.settingsFilterList.assertFilterListRowExists(filterId);
-      }
+      await ml.testExecution.logTestStep('filter list creation creates new filter lists');


I think this line could be removed as you're already logging more detailed test steps in the next lines.

Removed here db1bdd7

pheyos · 2020-09-18T10:47:21Z

@elasticmachine merge upstream

…ndarEvent, remove redundant log step

peteharverson

Latest edits LGTM

qn895 · 2020-09-18T16:32:55Z

@elasticmachine merge upstream

qn895 · 2020-09-22T13:10:02Z

@elasticmachine merge upstream

…msPopoverButton

kibanamachine · 2020-09-22T18:27:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 94c518d

Build metrics

async chunks size

id	value	diff	baseline
ml	8.1MB	+874.0B	8.1MB

History

💔 Build #76158 failed 55517a0
💔 Build #75627 failed 100751b
💔 Build #75547 failed db1bdd7
💔 Build #75494 failed 1d16bcf
💔 Build #75356 failed 9cb3caa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ndars and Filter Lists (elastic#77566) Co-authored-by: Elastic Machine <[email protected]>

…r Calendars and Filter Lists (#77566) (#78198) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

qn895 added 4 commits September 15, 2020 19:05

[ML] Add tests for calendar and filter list

704ccb3

[ML] Add tests for calendar and filter list

ebc704b

[ML] Fix config

ee034fb

[ML] Update texts for delete

238ceb3

qn895 added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 16, 2020

qn895 requested review from pheyos and peteharverson September 16, 2020 00:27

qn895 requested a review from a team as a code owner September 16, 2020 00:27

qn895 self-assigned this Sep 16, 2020

pheyos reviewed Sep 16, 2020

View reviewed changes

qn895 added 5 commits September 16, 2020 17:46

Merge remote-tracking branch 'upstream/master' into ml-calendar-filte…

1e30e0a

…rlist-tests

[ML] Rename data subj test and remove redundant navigate

2e1638d

[ML] Update translations

86be3af

[ML] Update snapshots

2f2970d

[ML] Update commented code

99ca93f

qn895 requested a review from a team as a code owner September 16, 2020 23:36

peteharverson reviewed Sep 17, 2020

View reviewed changes

pheyos reviewed Sep 17, 2020

View reviewed changes

qn895 added 2 commits September 17, 2020 09:27

[ML] Fix config

72dc430

[ML] Rename mlFilterListOpenNewItemsPopoverButton & mlFilterListAddIt…

a16a54b

…emButton, update snapshots, add more assertions

pheyos reviewed Sep 17, 2020

View reviewed changes

qn895 added 3 commits September 17, 2020 11:20

[ML] Update test descriptions and log steps

1fd5fa7

[ML] Remove testSubjects in the test suites

f38947f

[ML] Remove testSubjects in the test suites, rename log steps, add va…

20c6b2d

…lidation for post edit

qn895 removed the request for review from a team September 17, 2020 19:08

[ML] Fix assertApplyToAllJobsSwitchCheckedState

15304af

pheyos approved these changes Sep 18, 2020

View reviewed changes

elasticmachine and others added 2 commits September 18, 2020 04:47

Merge branch 'master' into ml-calendar-filterlist-tests

1d16bcf

[ML] Fix assertApplyToAllJobsSwitchCheckedState, remove createNewCale…

db1bdd7

…ndarEvent, remove redundant log step

peteharverson approved these changes Sep 18, 2020

View reviewed changes

Merge branch 'master' into ml-calendar-filterlist-tests

100751b

elasticmachine and others added 3 commits September 22, 2020 09:10

Merge branch 'master' into ml-calendar-filterlist-tests

55517a0

[ML] Replace ml.commonConfig

b5af3e6

[ML] Update assertAddItemsButtonEnabled to use mlFilterListOpenNewIte…

94c518d

…msPopoverButton

qn895 merged commit 426df45 into elastic:master Sep 22, 2020

qn895 deleted the ml-calendar-filterlist-tests branch September 22, 2020 18:43

qn895 mentioned this pull request Sep 22, 2020

[7.x] [ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists (#77566) #78198

Merged

qn895 added a commit to qn895/kibana that referenced this pull request Sep 22, 2020

[ML] Edit text for deleting calendars & add functional tests for Cale…

1ba340a

…ndars and Filter Lists (elastic#77566) Co-authored-by: Elastic Machine <[email protected]>

qn895 mentioned this pull request Sep 23, 2020

[ML] Improve UI for deleting calendars #76218

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists #77566

[ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists #77566

qn895 commented Sep 16, 2020

elasticmachine commented Sep 16, 2020

peteharverson Sep 17, 2020

pgayvallet Sep 17, 2020

qn895 Sep 17, 2020

qn895 commented Sep 17, 2020

pheyos left a comment

pheyos Sep 18, 2020

qn895 Sep 18, 2020

pheyos Sep 18, 2020

qn895 Sep 18, 2020

pheyos Sep 18, 2020

qn895 Sep 18, 2020

pheyos commented Sep 18, 2020

peteharverson left a comment

qn895 commented Sep 18, 2020

qn895 commented Sep 22, 2020

kibanamachine commented Sep 22, 2020

[ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists #77566

[ML] Edit text for deleting calendars & add functional tests for Calendars and Filter Lists #77566

Conversation

qn895 commented Sep 16, 2020

Summary

Checklist

elasticmachine commented Sep 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qn895 commented Sep 17, 2020

pheyos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pheyos commented Sep 18, 2020

peteharverson left a comment

Choose a reason for hiding this comment

qn895 commented Sep 18, 2020

qn895 commented Sep 22, 2020

kibanamachine commented Sep 22, 2020

💚 Build Succeeded

Build metrics

async chunks size

History