[Security Solution][Test] Enzyme test for related events button #74411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkimmel
added
v7.10.0
v8.0.0
Team:Endpoint Data Visibility
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
bkimmel
commented
Aug 5, 2020
| } | ||
|
|
||
| /** | ||
| * Dump all contents of the outer ReactWrapper (to be `console.log`ged as appropriate) |
There was a problem hiding this comment.
❔ add comment about mixing React & DOM
There was a problem hiding this comment.
bkimmel
commented
Aug 5, 2020
| entityID, | ||
| timestamp, | ||
| category, | ||
| type, |
There was a problem hiding this comment.
oatkiller
reviewed
Aug 5, 2020
| /** | ||
| * For a render of the Enzyme wrapper (may help update if other concerns have effected the render). May be useful for debugging. | ||
| */ | ||
| public updateWrapper() { |
There was a problem hiding this comment.
can you remove this for now (its unused)
There was a problem hiding this comment.
| public processNodeRelatedEventButton(entityID: string): ReactWrapper { | ||
| return this.processNodeElements({ entityID }).findWhere( | ||
| (wrapper) => | ||
| typeof wrapper.type() === 'string' && |
There was a problem hiding this comment.
can you add a comment here saying something like 'filter out React components'?
There was a problem hiding this comment.
| export function oneAncestorTwoChildren( | ||
| { | ||
| withRelatedEvents, | ||
| }: { withRelatedEvents: Parameters<typeof withRelatedEventsOnOrigin>[1] | null } = { |
There was a problem hiding this comment.
Suggested change
| }: { withRelatedEvents: Parameters<typeof withRelatedEventsOnOrigin>[1] | null } = { | |
| }: { withRelatedEvents: Parameters<[string, string] | null } = { |
There was a problem hiding this comment.
oatkiller
reviewed
Aug 5, 2020
| kind: 'event', | ||
| type, | ||
| category, | ||
| id: uuid.v4(), |
There was a problem hiding this comment.
can you make this non-random? maybe pass it in or just make it id: '1' or something
There was a problem hiding this comment.
bkimmel
commented
Aug 5, 2020
| export function oneAncestorTwoChildren( | ||
| { | ||
| withRelatedEvents, | ||
| }: { withRelatedEvents: Parameters<typeof withRelatedEventsOnOrigin>[1] | null } = { |
There was a problem hiding this comment.
❔ Change back to It<string,string>
There was a problem hiding this comment.
oatkiller
approved these changes
Aug 5, 2020
|
@elasticmachine merge upstream |
kqualters-elastic
approved these changes
Aug 5, 2020
michaelolo24
approved these changes
Aug 5, 2020
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 6, 2020
* master: (208 commits) Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465) [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010) Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073) Filter out non-security jobs when collecting Detections telemetry (elastic#74456) [Security Solution][Test] Enzyme test for related events button (elastic#74411) [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427) Rename package configs SO to package policies (elastic#74422) [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762) skip flaky suite (elastic#71390) [ML] DF Analytics: adds functional tests for edit form (elastic#73885) Rename agent configs SO to agent policies (elastic#74397) [Jenkins] run CI when plugin readmes change (elastic#74388) [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311) fixing encoding issue with \ for enroll command (elastic#74379) [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341) Change experimental message for visualizations (elastic#74354) [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715) [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323) update empty prompt in analytics list (elastic#74174) [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244) ...
bkimmel
added a commit
that referenced
this pull request
Aug 6, 2020
…) (#74520) Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an Enzyme test to assert the presence of a "Related Events" button on a node when that node has Related Events on the underlying Resolver tree.
To assist in this, a new mock was created to mock related events and a helper function to insert related events into a mock tree was added as well.
For maintainers