Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of html doc title with a prefix #73917

Conversation

kertal
Copy link
Member

@kertal kertal commented Jul 31, 2020

Summary

Experimental PR, just an idea. Having to deal with multiple Kibanas in parallel (local master, functional test server, cloud instances, local docker instances, ...) can lead to find-the-right-browser-tab situations. So why not making the html document title configureable by allowing a prefix?

Before:
Bildschirmfoto 2020-07-31 um 08 45 54

After:
Bildschirmfoto 2020-07-31 um 08 08 35

🔥_-_Discover_-_Elastic

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kertal kertal self-assigned this Jul 31, 2020
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jul 31, 2020
@marius-dr
Copy link
Member

I can see use for this not only for us. I recall customers asking for help on differentiating between different Kibana instances.

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 3, 2020

💔 Build Failed

Failed CI Steps

Build metrics

async chunks size

id value diff baseline
infra 3.6MB -42.0B 3.6MB
monitoring 1.1MB +10.0B 1.1MB
triggers_actions_ui 725.8KB -21.0B 725.8KB
total - -53.0B -

page load bundle size

id value diff baseline
core 1.2MB -1.2KB 1.2MB
data 1.4MB +9.0B 1.4MB
lens 841.0KB -21.0B 841.0KB
total - -1.2KB -

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Aug 4, 2020

Closing, because this should be solved like suggested in #35210

@kertal kertal closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants