Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Uptime] Use service.name to link from Uptime -> APM where available (#73618) #73666

Merged
merged 2 commits into from
Aug 5, 2020
Merged

[7.x] [Uptime] Use service.name to link from Uptime -> APM where available (#73618) #73666

merged 2 commits into from
Aug 5, 2020

Conversation

andrewvc
Copy link
Contributor

Backports the following commits to 7.x:

@andrewvc
[Uptime] Use service.name to link from Uptime -> APM where available (
d267483 
elastic#73618)

With elastic/beats#19932 coming in 7.10 adding
the `service.name` ECS field is very easy. We should prefer this field
when cross linking to APM, hence this PR.

Resolves elastic/uptime#220
# Conflicts:
#	x-pack/plugins/uptime/public/lib/helper/observability_integration/get_apm_href.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
uptime 1.5MB +800.0B 1.5MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrewvc andrewvc merged commit 4a4b1e0 into elastic:7.x Aug 5, 2020
@andrewvc andrewvc deleted the backport/7.x/pr-73618 branch August 5, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewvc @kibanamachine