Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Fix test failure due to race condition #73645

Closed
wants to merge 1 commit into from

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Jul 29, 2020

Summary

This fixes an intermittent test failure caused by a race condition between tests and the global jsdom object.

These tests are already skipped on 7.9, so no need to backport there.

Checklist

for features that require explanation or tutorials

For maintainers

Guards against this global method having already been set in another
test, as is happening here.
@rylnd rylnd added the v8.0.0 label Jul 29, 2020
@rylnd rylnd self-assigned this Jul 29, 2020
@rylnd
Copy link
Contributor Author

rylnd commented Jul 29, 2020

Closing in favor of #73639

@rylnd rylnd closed this Jul 29, 2020
@rylnd rylnd deleted the fix-download-tests branch July 29, 2020 09:12
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 29, 2020

💔 Build Failed

Failed CI Steps

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants