[Maps] Track geo_shape agg usage #71759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
added
chore
release_note:skip
nreese
reviewed
Jul 15, 2020
kindsun
reviewed
Jul 15, 2020
| function isGeoShapeAggLayer(indexPatterns: IIndexPattern[], layer: LayerDescriptor): boolean { | ||
| if (layer.sourceDescriptor === null) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Probably good to return early if no geoField here instead of on lines 119-121. You could revise this to:
const sourceDescriptor: SourceDescriptor = layer.sourceDescriptor;
if (!sourceDescriptor || !sourceDescriptor.geoField) {
return false;
}
There was a problem hiding this comment.
I'd prefer to avoid it, since we then lose typing-clarity and end up duck typing (which now we have TS there is no reason to. The TS-typecheck will fail with this pattern too). geoField is very specific to ES-sources, and that type-check appears higher-up.
💚 Build SucceededBuild metricsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 15, 2020
Tracks how many users are using geo_shape aggs.
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 15, 2020
Tracks how many users are using geo_shape aggs.
thomasneirynck
added a commit
that referenced
this pull request
Jul 15, 2020
thomasneirynck
added a commit
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69527
Tracks geo_shape aggregation usage as total number of layers that use geo_shape agg per cluster. (it can be used just as a boolean (0 = no gold+ use, >= 0 is gold+ use).
This also makes some TS-typing explicit in the telemetry-code.