[KP] Integrate Audit trail into new es client #71228

mshustov · 2020-07-09T12:21:52Z

Summary

Part of #35508
Integrates audit trail into new es client.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-07-09T12:21:55Z

Pinging @elastic/kibana-platform (Team:Platform)

mshustov · 2020-07-09T12:23:22Z

src/core/server/elasticsearch/integration_tests/auditor.test.ts

+  });
+
+  describe('Auditor', () => {
+    it('logs elasticsearch requests done on behalf on the current & internal user', async () => {


Should be moved to functional tests when the new ES client exposed to the plugins.

src/core/server/elasticsearch/client/cluster_client.ts

mshustov · 2020-07-28T08:23:48Z

src/core/server/elasticsearch/integration_tests/auditor.test.ts

+        await client.callAsInternalUser('ping');
+        expect(auditor.add).toHaveBeenCalledTimes(1);
+        expect(auditor.add).toHaveBeenCalledWith({
+          message: 'ping',


Note the difference in audit log record format between the legacy & new clients:

in the legacy client, it's not possible to access request method and path unless we auditor is integrated into ElasticsearchClientLogging class

in the new client RequestEvent doesn't contain client method name

I'm inclining towards keeping this as is until we have the format requirements.

joshdover · 2020-07-29T19:46:16Z

src/core/server/elasticsearch/legacy/scoped_cluster_client.ts

@@ -69,7 +69,7 @@ export class LegacyScopedClusterClient implements ILegacyScopedClusterClient {
    if (this.auditor) {
      this.auditor.add({
        message: endpoint,
-        type: 'elasticsearch.call.internalUser',
+        type: 'legacy.elasticsearch.call.internalUser',


I wonder if we should actually use the same type as the new client. From a user's perspective, I would consider it a bug if they filtered their audit logs on type: elasticsearch.call.* and they didn't get these events in their results. I know there are slight differences in the data we can expose depending on the client (https://github.com/elastic/kibana/pull/71228/files#r461405740), but it seems we should try to keep the events as similar as possible.

@jportner thoughts?

I tend to agree, but I think @thomheymann should weigh in too.

kibanamachine · 2020-08-06T13:26:37Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 5d39ab4
Flaky suites:
- xpack-kibana-ciGroup2

Test Failures

Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration·js.task_manager scheduling and running tasks should return a task run error result when trying to run a task now which is already running

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/71390

[00:00:00]       │
[00:00:00]         └-: task_manager
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: scheduling and running tasks
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should support middleware
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               └-> "before each" hook
[00:00:00]               └-> "before each" hook
[00:00:00]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1596713857745117140] [.kibana_task_manager_test_result] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]               │ debg Task created: 78346fd0-d7e0-11ea-839d-bf53e267f3d5
[00:00:00]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:00]               │ proc [kibana]   log   [12:29:27.902] [warning][plugins][reporting] Enabling the Chromium sandbox provides an additional layer of protection.
[00:00:01]               │ debg --- retry.try failed again with the same message...
[00:00:01]               │ debg --- retry.try failed again with the same message...
[00:00:01]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1596713857745117140] [ilm-history-2-000001] creating index, cause [api], templates [ilm-history], shards [1]/[0]
[00:00:01]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1596713857745117140] moving index [ilm-history-2-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [ilm-history-ilm-policy]
[00:00:01]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1596713857745117140] moving index [ilm-history-2-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [ilm-history-ilm-policy]
[00:00:01]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xxl-1596713857745117140] moving index [ilm-history-2-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [ilm-history-ilm-policy]
[00:00:02]               │ debg --- retry.try failed again with the same message...
[00:00:02]               │ debg --- retry.try failed again with the same message...
[00:00:02]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1596713857745117140] [.kibana_task_manager_test_result/yD8cjCDLTCm1fXmNGwskvQ] update_mapping [_doc]
[00:00:03]               │ debg Task found: 78346fd0-d7e0-11ea-839d-bf53e267f3d5
[00:00:03]               │ debg Task status: claiming
[00:00:03]               │ debg Task state: {}
[00:00:03]               │ debg Task params: {
[00:00:03]               │        "originalParams": {
[00:00:03]               │          "historyItem": 12
[00:00:03]               │        },
[00:00:03]               │        "superFly": "My middleware param!"
[00:00:03]               │      }
[00:00:03]               │ debg --- retry.try error: expected undefined to sort of equal 1
[00:00:03]               │ debg Task found: 78346fd0-d7e0-11ea-839d-bf53e267f3d5
[00:00:03]               │ debg Task status: idle
[00:00:03]               │ debg Task state: {
[00:00:03]               │        "count": 1
[00:00:03]               │      }
[00:00:03]               │ debg Task params: {
[00:00:03]               │        "originalParams": {
[00:00:03]               │          "historyItem": 12
[00:00:03]               │        },
[00:00:03]               │        "superFly": "My middleware param!"
[00:00:03]               │      }
[00:00:03]               └- ✓ pass  (3.2s) "task_manager scheduling and running tasks should support middleware"
[00:00:03]             └-> should remove non-recurring tasks after they complete
[00:00:03]               └-> "before each" hook: global before each
[00:00:03]               └-> "before each" hook
[00:00:04]               └-> "before each" hook
[00:00:04]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:05]               │ debg --- retry.try failed again with the same message...
[00:00:05]               │ debg --- retry.try failed again with the same message...
[00:00:06]               │ debg --- retry.try error: expected [ { taskType: 'sampleTask',
[00:00:06]               │          retryAt: '2020-08-06T12:30:02.788Z',
[00:00:06]               │          runAt: '2020-08-06T12:29:31.785Z',
[00:00:06]               │          scope: [ 'testing' ],
[00:00:06]               │          startedAt: null,
[00:00:06]               │          state: {},
[00:00:06]               │          params: 
[00:00:06]               │           { originalParams: {},
[00:00:06]               │             superFly: 'My middleware param!' },
[00:00:06]               │          ownerId: 'kibana:5b2de169-2785-441b-ae8c-186a1936b17d',
[00:00:06]               │          scheduledAt: '2020-08-06T12:29:31.785Z',
[00:00:06]               │          attempts: 0,
[00:00:06]               │          status: 'claiming',
[00:00:06]               │          id: '7a9b0f90-d7e0-11ea-839d-bf53e267f3d5' } ] to sort of equal []
[00:00:06]               └- ✓ pass  (2.4s) "task_manager scheduling and running tasks should remove non-recurring tasks after they complete"
[00:00:06]             └-> should use a given ID as the task document ID
[00:00:06]               └-> "before each" hook: global before each
[00:00:06]               └-> "before each" hook
[00:00:06]               └-> "before each" hook
[00:00:07]               └- ✓ pass  (19ms) "task_manager scheduling and running tasks should use a given ID as the task document ID"
[00:00:07]             └-> should allow a task with a given ID to be scheduled multiple times
[00:00:07]               └-> "before each" hook: global before each
[00:00:07]               └-> "before each" hook
[00:00:07]               └-> "before each" hook
[00:00:07]               │ proc [kibana]   log   [12:29:34.382] [error][data][elasticsearch] [version_conflict_engine_exception]: [task:test-task-to-reschedule-in-task-manager]: version conflict, document already exists (current version [1])
[00:00:07]               └- ✓ pass  (53ms) "task_manager scheduling and running tasks should allow a task with a given ID to be scheduled multiple times"
[00:00:07]             └-> should reschedule if task errors
[00:00:07]               └-> "before each" hook: global before each
[00:00:07]               └-> "before each" hook
[00:00:07]               └-> "before each" hook
[00:00:07]               │ debg --- retry.try error: Cannot read property 'id' of undefined
[00:00:07]               │ debg --- retry.try error: expected 'test-task-for-sample-task-plugin-to-test-task-manager' to sort of equal '7c2f1d10-d7e0-11ea-839d-bf53e267f3d5'
[00:00:08]               │ debg --- retry.try failed again with the same message...
[00:00:08]               │ proc [kibana]   log   [12:29:35.913] [error][plugins][taskManager][taskManager] Task sampleTask "7c2f1d10-d7e0-11ea-839d-bf53e267f3d5" failed: Error: Dangit!!!!!
[00:00:08]               │ debg --- retry.try failed again with the same message...
[00:00:09]               │ debg --- retry.try failed again with the same message...
[00:00:09]               └- ✓ pass  (2.7s) "task_manager scheduling and running tasks should reschedule if task errors"
[00:00:09]             └-> should reschedule if task returns runAt
[00:00:09]               └-> "before each" hook: global before each
[00:00:09]               └-> "before each" hook
[00:00:10]               └-> "before each" hook
[00:00:10]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:11]               │ debg --- retry.try failed again with the same message...
[00:00:11]               │ debg --- retry.try failed again with the same message...
[00:00:12]               │ debg --- retry.try failed again with the same message...
[00:00:12]               │ debg --- retry.try failed again with the same message...
[00:00:13]               │ debg --- retry.try failed again with the same message...
[00:00:13]               │ debg --- retry.try failed again with the same message...
[00:00:14]               │ debg --- retry.try failed again with the same message...
[00:00:14]               │ debg --- retry.try error: expected 10 to sort of equal 11
[00:00:15]               │ debg --- retry.try failed again with the same message...
[00:00:15]               └- ✓ pass  (5.2s) "task_manager scheduling and running tasks should reschedule if task returns runAt"
[00:00:15]             └-> should reschedule if task has an interval
[00:00:15]               └-> "before each" hook: global before each
[00:00:15]               └-> "before each" hook
[00:00:16]               └-> "before each" hook
[00:00:16]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:17]               │ debg --- retry.try failed again with the same message...
[00:00:17]               │ debg --- retry.try failed again with the same message...
[00:00:18]               │ debg --- retry.try failed again with the same message...
[00:00:18]               │ debg --- retry.try failed again with the same message...
[00:00:19]               │ debg --- retry.try failed again with the same message...
[00:00:19]               │ debg --- retry.try failed again with the same message...
[00:00:20]               │ debg --- retry.try failed again with the same message...
[00:00:20]               │ debg --- retry.try error: expected undefined to sort of equal 1
[00:00:21]               │ debg --- retry.try failed again with the same message...
[00:00:21]               └- ✓ pass  (5.2s) "task_manager scheduling and running tasks should reschedule if task has an interval"
[00:00:21]             └-> should support the deprecated interval field
[00:00:21]               └-> "before each" hook: global before each
[00:00:21]               └-> "before each" hook
[00:00:22]               └-> "before each" hook
[00:00:22]               │ proc [kibana]   log   [12:29:49.945] [warning][plugins][taskManager][taskManager] Task of type "sampleTask" has been scheduled with the deprecated 'interval' field which is due to be removed in a future release
[00:00:22]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:23]               │ debg --- retry.try failed again with the same message...
[00:00:23]               │ debg --- retry.try failed again with the same message...
[00:00:24]               │ debg --- retry.try failed again with the same message...
[00:00:24]               │ debg --- retry.try failed again with the same message...
[00:00:25]               │ debg --- retry.try failed again with the same message...
[00:00:25]               │ debg --- retry.try failed again with the same message...
[00:00:26]               │ debg --- retry.try failed again with the same message...
[00:00:26]               │ debg --- retry.try error: expected 1 to sort of equal 0
[00:00:27]               │ debg --- retry.try failed again with the same message...
[00:00:27]               └- ✓ pass  (5.2s) "task_manager scheduling and running tasks should support the deprecated interval field"
[00:00:27]             └-> should return a task run result when asked to run a task now
[00:00:27]               └-> "before each" hook: global before each
[00:00:27]               └-> "before each" hook
[00:00:28]               └-> "before each" hook
[00:00:28]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:29]               │ debg --- retry.try failed again with the same message...
[00:00:29]               │ debg --- retry.try failed again with the same message...
[00:00:30]               │ debg --- retry.try failed again with the same message...
[00:00:30]               │ debg --- retry.try failed again with the same message...
[00:00:31]               │ debg --- retry.try failed again with the same message...
[00:00:31]               │ debg --- retry.try failed again with the same message...
[00:00:32]               │ debg --- retry.try failed again with the same message...
[00:00:32]               │ debg --- retry.try error: expected undefined to sort of equal 1
[00:00:33]               │ debg --- retry.try failed again with the same message...
[00:00:34]               │ debg --- retry.try error: expected 1 to sort of equal 2
[00:00:34]               │ debg --- retry.try failed again with the same message...
[00:00:35]               └- ✓ pass  (6.5s) "task_manager scheduling and running tasks should return a task run result when asked to run a task now"
[00:00:35]             └-> should prioritize tasks which are called using runNow
[00:00:35]               └-> "before each" hook: global before each
[00:00:35]               └-> "before each" hook
[00:00:35]               └-> "before each" hook
[00:00:35]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:36]               │ debg --- retry.try failed again with the same message...
[00:00:36]               │ debg --- retry.try failed again with the same message...
[00:00:37]               │ debg --- retry.try failed again with the same message...
[00:00:37]               │ debg --- retry.try failed again with the same message...
[00:00:38]               │ debg --- retry.try failed again with the same message...
[00:00:47]               │ debg --- retry.try error: expected 10 to sort of equal 0
[00:00:48]               │ debg --- retry.try error: expected 7 to sort of equal 0
[00:00:48]               │ debg --- retry.try failed again with the same message...
[00:00:49]               │ debg --- retry.try failed again with the same message...
[00:00:49]               │ debg --- retry.try failed again with the same message...
[00:00:50]               │ debg --- retry.try failed again with the same message...
[00:00:50]               │ debg --- retry.try failed again with the same message...
[00:00:51]               │ debg --- retry.try failed again with the same message...
[00:00:52]               └- ✓ pass  (16.2s) "task_manager scheduling and running tasks should prioritize tasks which are called using runNow"
[00:00:52]             └-> should return a task run error result when running a task now fails
[00:00:52]               └-> "before each" hook: global before each
[00:00:52]               └-> "before each" hook
[00:00:52]               └-> "before each" hook
[00:00:53]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:00:53]               │ debg --- retry.try failed again with the same message...
[00:00:54]               │ debg --- retry.try failed again with the same message...
[00:00:54]               │ debg --- retry.try failed again with the same message...
[00:00:55]               │ debg --- retry.try failed again with the same message...
[00:00:55]               │ debg --- retry.try failed again with the same message...
[00:00:56]               │ debg --- retry.try failed again with the same message...
[00:00:56]               │ debg --- retry.try failed again with the same message...
[00:00:57]               │ proc [kibana]   log   [12:30:24.769] [error][plugins][taskManager][taskManager] Task sampleTask "97847d30-d7e0-11ea-839d-bf53e267f3d5" failed: Error: this task was meant to fail!
[00:00:57]               └- ✓ pass  (4.6s) "task_manager scheduling and running tasks should return a task run error result when running a task now fails"
[00:00:57]             └-> should return a task run error result when trying to run a non-existent task
[00:00:57]               └-> "before each" hook: global before each
[00:00:57]               └-> "before each" hook
[00:00:58]               └-> "before each" hook
[00:00:58]               └- ✓ pass  (32ms) "task_manager scheduling and running tasks should return a task run error result when trying to run a non-existent task"
[00:00:58]             └-> should return a task run error result when trying to run a task now which is already running
[00:00:58]               └-> "before each" hook: global before each
[00:00:58]               └-> "before each" hook
[00:00:58]               └-> "before each" hook
[00:00:58]               │ debg --- retry.try error: Cannot read property 'status' of undefined
[00:00:58]               │ debg --- retry.try failed again with the same message...
[00:00:59]               │ debg --- retry.try error: expected 'idle' to sort of equal 'running'
[00:00:59]               │ debg --- retry.try error: expected 'claiming' to sort of equal 'running'
[00:01:00]               │ debg --- retry.try error: expected 0 to sort of equal 1
[00:01:00]               │ proc [kibana]   log   [12:30:28.074] [warning][plugins][taskManager][taskManager] [Task Ownership error]: 1 tasks were claimed by Kibana, but 2 task(s) were fetched (endpoint:user-artifact-packager:1.0.0, 9a8c8d10-d7e0-11ea-839d-bf53e267f3d5)
[00:01:00]               │ debg --- retry.try error: expected undefined to sort of equal 1
[00:01:01]               │ debg --- retry.try error: expected 'idle' to sort of equal 'running'
[00:01:01]               │ debg --- retry.try failed again with the same message...
[00:01:02]               │ debg --- retry.try failed again with the same message...
[00:01:02]               │ debg --- retry.try failed again with the same message...
[00:01:03]               │ debg --- retry.try failed again with the same message...
[00:01:03]               │ debg --- retry.try failed again with the same message...
[00:01:04]               │ debg --- retry.try failed again with the same message...
[00:01:05]               │ debg --- retry.try failed again with the same message...
[00:01:05]               │ debg --- retry.try failed again with the same message...
[00:01:06]               │ debg --- retry.try failed again with the same message...
[00:01:06]               │ debg --- retry.try failed again with the same message...
[00:01:07]               │ debg --- retry.try failed again with the same message...
[00:01:07]               │ debg --- retry.try failed again with the same message...
[00:01:08]               │ debg --- retry.try failed again with the same message...
[00:01:08]               │ debg --- retry.try failed again with the same message...
[00:01:09]               │ debg --- retry.try failed again with the same message...
[00:01:09]               │ debg --- retry.try failed again with the same message...
[00:01:10]               │ debg --- retry.try failed again with the same message...
[00:01:10]               │ debg --- retry.try failed again with the same message...
[00:01:11]               │ debg --- retry.try failed again with the same message...
[00:01:11]               │ debg --- retry.try failed again with the same message...
[00:01:12]               │ debg --- retry.try failed again with the same message...
[00:01:12]               │ debg --- retry.try failed again with the same message...
[00:01:13]               │ debg --- retry.try failed again with the same message...
[00:01:13]               │ debg --- retry.try failed again with the same message...
[00:01:14]               │ debg --- retry.try failed again with the same message...
[00:01:14]               │ debg --- retry.try failed again with the same message...
[00:01:15]               │ debg --- retry.try failed again with the same message...
[00:01:15]               │ debg --- retry.try failed again with the same message...
[00:01:16]               │ debg --- retry.try failed again with the same message...
[00:01:16]               │ debg --- retry.try failed again with the same message...
[00:01:17]               │ debg --- retry.try failed again with the same message...
[00:01:17]               │ debg --- retry.try failed again with the same message...
[00:01:18]               │ debg --- retry.try failed again with the same message...
[00:01:19]               │ debg --- retry.try failed again with the same message...
[00:01:19]               │ debg --- retry.try failed again with the same message...
[00:01:20]               │ debg --- retry.try failed again with the same message...
[00:01:20]               │ debg --- retry.try failed again with the same message...
[00:01:21]               │ debg --- retry.try failed again with the same message...
[00:01:21]               │ debg --- retry.try failed again with the same message...
[00:01:22]               │ debg --- retry.try failed again with the same message...
[00:01:22]               │ debg --- retry.try failed again with the same message...
[00:01:23]               │ debg --- retry.try failed again with the same message...
[00:01:23]               │ debg --- retry.try failed again with the same message...
[00:01:24]               │ debg --- retry.try failed again with the same message...
[00:01:24]               │ debg --- retry.try failed again with the same message...
[00:01:25]               │ debg --- retry.try failed again with the same message...
[00:01:25]               │ debg --- retry.try failed again with the same message...
[00:01:26]               │ debg --- retry.try failed again with the same message...
[00:01:26]               │ debg --- retry.try failed again with the same message...
[00:01:27]               │ debg --- retry.try failed again with the same message...
[00:01:27]               │ debg --- retry.try failed again with the same message...
[00:01:28]               │ debg --- retry.try failed again with the same message...
[00:01:28]               │ debg --- retry.try failed again with the same message...
[00:01:29]               │ debg --- retry.try failed again with the same message...
[00:01:29]               │ debg --- retry.try failed again with the same message...
[00:01:30]               │ debg --- retry.try failed again with the same message...
[00:01:30]               │ debg --- retry.try failed again with the same message...
[00:01:31]               │ debg --- retry.try failed again with the same message...
[00:01:31]               │ debg --- retry.try failed again with the same message...
[00:01:32]               │ debg --- retry.try failed again with the same message...
[00:01:33]               │ debg --- retry.try failed again with the same message...
[00:01:33]               │ debg --- retry.try failed again with the same message...
[00:01:34]               │ debg --- retry.try failed again with the same message...
[00:01:34]               │ debg --- retry.try failed again with the same message...
[00:01:35]               │ debg --- retry.try failed again with the same message...
[00:01:35]               │ debg --- retry.try failed again with the same message...
[00:01:36]               │ debg --- retry.try failed again with the same message...
[00:01:36]               │ debg --- retry.try failed again with the same message...
[00:01:37]               │ debg --- retry.try failed again with the same message...
[00:01:37]               │ debg --- retry.try failed again with the same message...
[00:01:38]               │ debg --- retry.try failed again with the same message...
[00:01:38]               │ debg --- retry.try failed again with the same message...
[00:01:39]               │ debg --- retry.try failed again with the same message...
[00:01:39]               │ debg --- retry.try failed again with the same message...
[00:01:40]               │ debg --- retry.try failed again with the same message...
[00:01:40]               │ debg --- retry.try failed again with the same message...
[00:01:41]               │ debg --- retry.try failed again with the same message...
[00:01:41]               │ debg --- retry.try failed again with the same message...
[00:01:42]               │ debg --- retry.try failed again with the same message...
[00:01:42]               │ debg --- retry.try failed again with the same message...
[00:01:43]               │ debg --- retry.try failed again with the same message...
[00:01:43]               │ debg --- retry.try failed again with the same message...
[00:01:44]               │ debg --- retry.try failed again with the same message...
[00:01:44]               │ debg --- retry.try failed again with the same message...
[00:01:45]               │ debg --- retry.try failed again with the same message...
[00:01:45]               │ debg --- retry.try failed again with the same message...
[00:01:46]               │ debg --- retry.try failed again with the same message...
[00:01:47]               │ debg --- retry.try failed again with the same message...
[00:01:47]               │ debg --- retry.try failed again with the same message...
[00:01:48]               │ debg --- retry.try failed again with the same message...
[00:01:48]               │ debg --- retry.try failed again with the same message...
[00:01:49]               │ debg --- retry.try failed again with the same message...
[00:01:49]               │ debg --- retry.try failed again with the same message...
[00:01:50]               │ debg --- retry.try failed again with the same message...
[00:01:50]               │ debg --- retry.try failed again with the same message...
[00:01:51]               │ debg --- retry.try failed again with the same message...
[00:01:51]               │ debg --- retry.try failed again with the same message...
[00:01:52]               │ debg --- retry.try failed again with the same message...
[00:01:52]               │ debg --- retry.try failed again with the same message...
[00:01:53]               │ debg --- retry.try failed again with the same message...
[00:01:53]               │ debg --- retry.try failed again with the same message...
[00:01:54]               │ debg --- retry.try failed again with the same message...
[00:01:54]               │ debg --- retry.try failed again with the same message...
[00:01:55]               │ debg --- retry.try failed again with the same message...
[00:01:55]               │ debg --- retry.try failed again with the same message...
[00:01:56]               │ debg --- retry.try failed again with the same message...
[00:01:56]               │ debg --- retry.try failed again with the same message...
[00:01:57]               │ debg --- retry.try failed again with the same message...
[00:01:57]               │ debg --- retry.try failed again with the same message...
[00:01:58]               │ debg --- retry.try failed again with the same message...
[00:01:58]               │ debg --- retry.try failed again with the same message...
[00:01:59]               │ debg --- retry.try failed again with the same message...
[00:02:00]               │ debg --- retry.try failed again with the same message...
[00:02:00]               │ debg --- retry.try failed again with the same message...
[00:02:01]               │ debg --- retry.try failed again with the same message...
[00:02:01]               │ debg --- retry.try failed again with the same message...
[00:02:02]               │ debg --- retry.try failed again with the same message...
[00:02:02]               │ debg --- retry.try failed again with the same message...
[00:02:03]               │ debg --- retry.try failed again with the same message...
[00:02:03]               │ debg --- retry.try failed again with the same message...
[00:02:04]               │ debg --- retry.try failed again with the same message...
[00:02:04]               │ debg --- retry.try failed again with the same message...
[00:02:05]               │ debg --- retry.try failed again with the same message...
[00:02:05]               │ debg --- retry.try failed again with the same message...
[00:02:06]               │ debg --- retry.try failed again with the same message...
[00:02:06]               │ debg --- retry.try failed again with the same message...
[00:02:07]               │ debg --- retry.try failed again with the same message...
[00:02:07]               │ debg --- retry.try failed again with the same message...
[00:02:08]               │ debg --- retry.try failed again with the same message...
[00:02:08]               │ debg --- retry.try failed again with the same message...
[00:02:09]               │ debg --- retry.try failed again with the same message...
[00:02:09]               │ debg --- retry.try failed again with the same message...
[00:02:10]               │ debg --- retry.try failed again with the same message...
[00:02:10]               │ debg --- retry.try failed again with the same message...
[00:02:11]               │ debg --- retry.try failed again with the same message...
[00:02:11]               │ debg --- retry.try failed again with the same message...
[00:02:12]               │ debg --- retry.try failed again with the same message...
[00:02:12]               │ debg --- retry.try failed again with the same message...
[00:02:13]               │ debg --- retry.try failed again with the same message...
[00:02:13]               │ debg --- retry.try failed again with the same message...
[00:02:14]               │ debg --- retry.try failed again with the same message...
[00:02:15]               │ debg --- retry.try failed again with the same message...
[00:02:15]               │ debg --- retry.try failed again with the same message...
[00:02:16]               │ debg --- retry.try failed again with the same message...
[00:02:16]               │ debg --- retry.try failed again with the same message...
[00:02:17]               │ debg --- retry.try failed again with the same message...
[00:02:17]               │ debg --- retry.try failed again with the same message...
[00:02:18]               │ debg --- retry.try failed again with the same message...
[00:02:18]               │ debg --- retry.try failed again with the same message...
[00:02:19]               │ debg --- retry.try failed again with the same message...
[00:02:19]               │ debg --- retry.try failed again with the same message...
[00:02:20]               │ debg --- retry.try failed again with the same message...
[00:02:20]               │ debg --- retry.try failed again with the same message...
[00:02:21]               │ debg --- retry.try failed again with the same message...
[00:02:21]               │ debg --- retry.try failed again with the same message...
[00:02:22]               │ debg --- retry.try failed again with the same message...
[00:02:22]               │ debg --- retry.try failed again with the same message...
[00:02:23]               │ debg --- retry.try failed again with the same message...
[00:02:23]               │ debg --- retry.try failed again with the same message...
[00:02:24]               │ debg --- retry.try failed again with the same message...
[00:02:24]               │ debg --- retry.try failed again with the same message...
[00:02:25]               │ debg --- retry.try failed again with the same message...
[00:02:25]               │ debg --- retry.try failed again with the same message...
[00:02:26]               │ debg --- retry.try failed again with the same message...
[00:02:26]               │ debg --- retry.try failed again with the same message...
[00:02:27]               │ debg --- retry.try failed again with the same message...
[00:02:27]               │ debg --- retry.try failed again with the same message...
[00:02:28]               │ debg --- retry.try failed again with the same message...
[00:02:28]               │ debg --- retry.try failed again with the same message...
[00:02:29]               │ debg --- retry.try failed again with the same message...
[00:02:30]               │ debg --- retry.try failed again with the same message...
[00:02:30]               │ debg --- retry.try failed again with the same message...
[00:02:31]               │ debg --- retry.try failed again with the same message...
[00:02:31]               │ debg --- retry.try failed again with the same message...
[00:02:32]               │ debg --- retry.try failed again with the same message...
[00:02:32]               │ debg --- retry.try failed again with the same message...
[00:02:33]               │ debg --- retry.try failed again with the same message...
[00:02:33]               │ debg --- retry.try failed again with the same message...
[00:02:34]               │ debg --- retry.try failed again with the same message...
[00:02:34]               │ debg --- retry.try failed again with the same message...
[00:02:35]               │ debg --- retry.try failed again with the same message...
[00:02:35]               │ debg --- retry.try failed again with the same message...
[00:02:36]               │ debg --- retry.try failed again with the same message...
[00:02:36]               │ debg --- retry.try failed again with the same message...
[00:02:37]               │ debg --- retry.try failed again with the same message...
[00:02:37]               │ debg --- retry.try failed again with the same message...
[00:02:38]               │ debg --- retry.try failed again with the same message...
[00:02:38]               │ debg --- retry.try failed again with the same message...
[00:02:39]               │ debg --- retry.try failed again with the same message...
[00:02:39]               │ debg --- retry.try failed again with the same message...
[00:02:40]               │ debg --- retry.try failed again with the same message...
[00:02:40]               │ debg --- retry.try failed again with the same message...
[00:02:41]               │ debg --- retry.try failed again with the same message...
[00:02:41]               │ debg --- retry.try failed again with the same message...
[00:02:42]               │ debg --- retry.try failed again with the same message...
[00:02:42]               │ debg --- retry.try failed again with the same message...
[00:02:43]               │ debg --- retry.try failed again with the same message...
[00:02:43]               │ debg --- retry.try failed again with the same message...
[00:02:44]               │ debg --- retry.try failed again with the same message...
[00:02:45]               │ debg --- retry.try failed again with the same message...
[00:02:45]               │ debg --- retry.try failed again with the same message...
[00:02:46]               │ debg --- retry.try failed again with the same message...
[00:02:46]               │ debg --- retry.try failed again with the same message...
[00:02:47]               │ debg --- retry.try failed again with the same message...
[00:02:47]               │ debg --- retry.try failed again with the same message...
[00:02:48]               │ debg --- retry.try failed again with the same message...
[00:02:48]               │ debg --- retry.try failed again with the same message...
[00:02:49]               │ debg --- retry.try failed again with the same message...
[00:02:49]               │ debg --- retry.try failed again with the same message...
[00:02:50]               │ debg --- retry.try failed again with the same message...
[00:02:50]               │ debg --- retry.try failed again with the same message...
[00:02:51]               │ debg --- retry.try failed again with the same message...
[00:02:51]               │ debg --- retry.try failed again with the same message...
[00:02:52]               │ debg --- retry.try failed again with the same message...
[00:02:52]               │ debg --- retry.try failed again with the same message...
[00:02:53]               │ debg --- retry.try failed again with the same message...
[00:02:53]               │ debg --- retry.try failed again with the same message...
[00:02:54]               │ debg --- retry.try failed again with the same message...
[00:02:54]               │ debg --- retry.try failed again with the same message...
[00:02:55]               │ debg --- retry.try failed again with the same message...
[00:02:55]               │ debg --- retry.try failed again with the same message...
[00:02:56]               │ debg --- retry.try failed again with the same message...
[00:02:56]               │ debg --- retry.try failed again with the same message...
[00:02:57]               │ debg --- retry.try failed again with the same message...
[00:02:57]               │ debg --- retry.try failed again with the same message...
[00:02:58]               │ debg --- retry.try failed again with the same message...
[00:02:58]               │ debg --- retry.try failed again with the same message...
[00:02:59]               │ debg --- retry.try failed again with the same message...
[00:02:59]               │ debg --- retry.try failed again with the same message...
[00:03:00]               │ debg --- retry.try failed again with the same message...
[00:03:01]               │ debg --- retry.try failed again with the same message...
[00:03:01]               └- ✖ fail: task_manager scheduling and running tasks should return a task run error result when trying to run a task now which is already running
[00:03:01]               │      retry.try timeout: Error: expected 'idle' to sort of equal 'running'
[00:03:01]               │     at Assertion.assert (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:100:11)
[00:03:01]               │     at Assertion.eql (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:244:8)
[00:03:01]               │     at retry.try (/dev/shm/workspace/parallel/7/kibana/x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration.js:131:54)
[00:03:01]               │   Error: retry.try timeout: Error: expected 'idle' to sort of equal 'running'
[00:03:01]               │       at Assertion.assert (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:100:11)
[00:03:01]               │       at Assertion.eql (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:244:8)
[00:03:01]               │       at retry.try (test/plugin_api_integration/test_suites/task_manager/task_manager_integration.js:131:54)
[00:03:01]               │       at onFailure (/dev/shm/workspace/parallel/7/kibana/test/common/services/retry/retry_for_success.ts:28:9)
[00:03:01]               │       at retryForSuccess (/dev/shm/workspace/parallel/7/kibana/test/common/services/retry/retry_for_success.ts:68:13)
[00:03:01]               │ 
[00:03:01]               │

Stack Trace

Error: retry.try timeout: Error: expected 'idle' to sort of equal 'running'
    at Assertion.assert (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:244:8)
    at retry.try (test/plugin_api_integration/test_suites/task_manager/task_manager_integration.js:131:54)
    at onFailure (/dev/shm/workspace/parallel/7/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/parallel/7/kibana/test/common/services/retry/retry_for_success.ts:68:13)

Build metrics

✅ unchanged

History

💚 Build #64620 succeeded 21f9cd1
💔 Build #64603 failed ff610d8
💔 Build #64354 failed 1f5539b
💔 Build #64320 failed 9ebb333
💔 Build #60205 failed 7d546d7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mshustov · 2020-08-30T08:06:25Z

not needed anymore #74640 (comment)

mshustov added 4 commits July 9, 2020 14:05

add legacy prefix for events from legacy ES client

45a63d9

integrate auditor into new ES client

8ebea72

add integration test

dd1956a

update tests

af0b98e

mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 9, 2020

mshustov requested a review from a team as a code owner July 9, 2020 12:21

mshustov commented Jul 9, 2020

View reviewed changes

src/core/server/elasticsearch/client/cluster_client.ts Outdated Show resolved Hide resolved

mshustov commented Jul 9, 2020

View reviewed changes

src/core/server/elasticsearch/client/cluster_client.ts Outdated Show resolved Hide resolved

epixa mentioned this pull request Jul 9, 2020

Use new elasticsearch-js client in Elasticsearch service #35508

Closed

14 tasks

mshustov added 2 commits July 9, 2020 15:03

Merge branch 'master' into audit-trail-new-es-client

df6ff35

fix reference

7d546d7

delvedor mentioned this pull request Jul 9, 2020

Allow the client name to be a symbol elastic/elasticsearch-js#1254

Merged

mshustov marked this pull request as draft July 12, 2020 08:44

mshustov added v7.10.0 and removed v7.9.0 labels Jul 16, 2020

mshustov added 9 commits July 22, 2020 09:25

Merge branch 'master' into audit-trail-new-es-client

944b0d8

pass auditor through request context

8ea2888

Merge branch 'master' into audit-trail-new-es-client

d2ab460

fix error after merging master

93dcff9

pass auditor factory getter lazily to prevent runtime excpetion

cbbf269

rename tests to show they verify the legacy client

d3e4d35

improve tests

9ebb333

fix tests

1f5539b

fix integration tests

d792de8

mshustov added 2 commits July 28, 2020 08:44

Merge branch 'master' into audit-trail-new-es-client

e66c842

move types

ff610d8

mshustov commented Jul 28, 2020

View reviewed changes

improve naming

21f9cd1

mshustov marked this pull request as ready for review July 28, 2020 08:30

joshdover reviewed Jul 29, 2020

View reviewed changes

Merge branch 'master' into audit-trail-new-es-client

5d39ab4

mshustov closed this Aug 30, 2020

mshustov deleted the audit-trail-new-es-client branch August 30, 2020 08:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KP] Integrate Audit trail into new es client #71228

[KP] Integrate Audit trail into new es client #71228

mshustov commented Jul 9, 2020

elasticmachine commented Jul 9, 2020

mshustov Jul 9, 2020

mshustov Jul 28, 2020

joshdover Jul 29, 2020

jportner Jul 30, 2020 •

edited

Loading

kibanamachine commented Aug 6, 2020

Standard Out

Stack Trace

mshustov commented Aug 30, 2020

[KP] Integrate Audit trail into new es client #71228

[KP] Integrate Audit trail into new es client #71228

Conversation

mshustov commented Jul 9, 2020

Summary

Checklist

For maintainers

elasticmachine commented Jul 9, 2020

mshustov Jul 9, 2020

Choose a reason for hiding this comment

mshustov Jul 28, 2020

Choose a reason for hiding this comment

joshdover Jul 29, 2020

Choose a reason for hiding this comment

jportner Jul 30, 2020 • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Aug 6, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Build metrics

History

mshustov commented Aug 30, 2020

jportner Jul 30, 2020 •

edited

Loading