Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes inspector plugin dependency on share plugin #70783

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Removes inspector plugin dependency on share plugin #70783

merged 2 commits into from
Jul 7, 2020

Conversation

streamich
Copy link
Contributor

Closes #69867

@streamich streamich requested a review from a team as a code owner July 6, 2020 10:36
@streamich streamich requested review from VladLasitsa and rudolf July 6, 2020 10:36
@streamich streamich added Feature:Inspector Inspector infrastructure and implementations Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.9.0 v8.0.0 labels Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

ppisljar
ppisljar approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 8ee4945 into elastic:master Jul 7, 2020
@streamich streamich mentioned this pull request Jul 7, 2020
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 9, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

5 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@mattkime mattkime added v7.10.0 and removed v7.9.0 labels Jul 16, 2020
@mattkime mattkime mentioned this pull request Jul 16, 2020
Merged
mattkime pushed a commit to mattkime/kibana that referenced this pull request Jul 16, 2020
@streamich @mattkime
fix: 🐛 remove inspector plugin dependency on share plugin (elastic#70783
0e6ef04 
)
mattkime added a commit that referenced this pull request Jul 16, 2020
@mattkime @streamich @elasticmachine
[7.x] fix: 🐛 remove inspector plugin dependency on share plugin (#70783…
7fd8d17 
…) (#72118)

* fix: 🐛 remove inspector plugin dependency on share plugin (#70783)

* remove share as required bundle

Co-authored-by: Vadim Dalecky <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
streamich added a commit that referenced this pull request Jul 17, 2020
@streamich @elasticmachine
[7.x] fix: 🐛 remove inspector plugin dependency on share plugin (#70783…
9881383 
…) (#70961)

* fix: 🐛 remove inspector plugin dependency on share plugin (#70783)

* fix: 🐛 remove "inspector" from "share" dependencies

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@rudolf rudolf Awaiting requested review from rudolf

Assignees
No one assigned
Labels
Feature:Inspector Inspector infrastructure and implementations Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspector imports code from the share plugin without declaring explicit dependency
5 participants
@streamich @elasticmachine @kibanamachine @ppisljar @mattkime