-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing sum in histogram if mode is set to total #702
Conversation
∑ |
@olej-a like this? :) |
exactly |
@olej-a, |
sigma ok, may be missing "hits" word in parentheses |
@olej-a makes sense, updated |
Great Update, Thanks 👍 |
@rashidkpc any feedback? |
Looks good, though maybe it would be better to not even show the count? Showing the count and the total makes the legend values really long. |
Count helps to understand diversity of data. If one query gives 10 hits and sum is 100 000, and other query gives 1000 hits and sum is 1000, that could help to understand data. |
I fixed this with the latest master, it should work as before. |
+1 |
Conflicts fixed it anyone cares. |
Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary. The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here. If you're looking for the old Kibana 3 code you can find it here. |
* Added EUI to color picker * Cleaned up styles * Fixed label margin in series style simple template * Added style to hackery.scss
In "total" mode:
other modes look as before:
Very convenient if you use "total". Turns out that people don't like to calculate sums themselves.